[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#153620: marked as done (md5sum: MD5 file parser problems)



Your message dated Thu, 29 Aug 2002 15:34:01 -0500 (CDT)
with message-id <Pine.LNX.4.33.0208291533160.6356-100000@gradall.private.brainfood.com>
and subject line Bug#153620: md5sum: MD5 file parser problems
has caused the attached Bug report to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere.  Please contact me immediately.)

Debian bug tracking system administrator
(administrator, Debian Bugs database)

--------------------------------------
Received: (at submit) by bugs.debian.org; 19 Jul 2002 22:08:11 +0000
>From adam@os.inf.tu-dresden.de Fri Jul 19 17:08:11 2002
Return-path: <adam@os.inf.tu-dresden.de>
Received: from os.inf.tu-dresden.de [141.76.48.99] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 17Vfuz-0002dA-00; Fri, 19 Jul 2002 17:08:10 -0500
Received: from moros.inf.tu-dresden.de
	([141.76.48.40] helo=moros ident=mail)
	by os.inf.tu-dresden.de with esmtp (Exim 3.36)
	id 17Vfuy-000v9E-00
	for submit@bugs.debian.org; Sat, 20 Jul 2002 00:08:08 +0200
Received: from adam by moros with local (Exim 3.35 #1 (Debian))
	id 17Vfux-0001VH-00
	for <submit@bugs.debian.org>; Sat, 20 Jul 2002 00:08:07 +0200
Date: Sat, 20 Jul 2002 00:08:07 +0200
From: Adam Lackorzynski <adam@os.inf.tu-dresden.de>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: md5sum: MD5 file parser problems
Message-ID: <20020719220807.GA5773@os.inf.tu-dresden.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
User-Agent: Mutt/1.4i
X-Reportbug-Version: 1.99.47
Sender: Adam Lackorzynski <adam@moros>
Delivered-To: submit@bugs.debian.org

Package: dpkg
Version: 1.10.4
Severity: normal
Tags: patch


Trying to check signed MD5SUMS from cdimage.d.o gives me the following
error:

md5sum -vc MD5SUMS 
debian-22r7-alpha-binary-1.iso OK
debian-22r7-alpha-binary-1_NONUS.iso OK
debian-22r7-alpha-binary-2.iso       OK
debian-22r7-alpha-binary-3.iso       OK
debian-22r7-alpha-binan              md5sum: can't open debian-22r7-alpha-binan
FAILED
md5sum: 1 of 5 file(s) failed MD5 check


The following patch fixes the parsing issue of MD5SUMS:

--- md5sum.c.orig	Mon May 20 07:56:01 2002
+++ md5sum.c	Fri Jul 19 23:46:25 2002
@@ -222,6 +222,11 @@
 	if (fgets(buf, sizeof(buf), fp) == NULL)
 		return -1;
 
+	/* check if start of buf looks like a digest */
+	for (i = 0; i < 32; i++)
+		if (hex_digit(buf[i]) == -1)
+			return 0;
+
 	memcpy(digest, p, 32);
 	p += 32;
 	if (*p++ != ' ')


-- System Information:
Debian Release: testing/unstable
Architecture: ia64
Kernel: Linux moros 2.4.18-p020508 #1 SMP Thu May 23 13:24:21 CEST 2002 ia64
Locale: LANG=C, LC_CTYPE=C

Versions of packages dpkg depends on:
ii  dselect                       1.10.4     a user tool to manage Debian packa
ii  libc6.1                       2.2.5-6    GNU C Library: Shared libraries an

-- no debconf information


Adam
-- 
Adam                 adam@os.inf.tu-dresden.de
  Lackorzynski         http://os.inf.tu-dresden.de/~adam/

-- System Information:
Debian Release: testing/unstable
Architecture: ia64
Kernel: Linux moros 2.4.18-p020508 #1 SMP Thu May 23 13:24:21 CEST 2002 ia64
Locale: LANG=C, LC_CTYPE=C

Versions of packages dpkg depends on:
ii  dselect                       1.10.4     a user tool to manage Debian packa
ii  libc6.1                       2.2.5-6    GNU C Library: Shared libraries an

-- no debconf information


Adam
-- 
Adam                 adam@os.inf.tu-dresden.de
  Lackorzynski         http://os.inf.tu-dresden.de/~adam/

---------------------------------------
Received: (at 153620-done) by bugs.debian.org; 29 Aug 2002 20:32:12 +0000
>From doogie@debian.org Thu Aug 29 15:32:12 2002
Return-path: <doogie@debian.org>
Received: from boof.brainfood.com (gradall.private.brainfood.com) [65.125.64.189] 
	by master.debian.org with esmtp (Exim 3.12 1 (Debian))
	id 17kVxW-0000oA-00; Thu, 29 Aug 2002 15:32:06 -0500
Received: from localhost ([127.0.0.1])
	by gradall.private.brainfood.com with esmtp (Exim 3.35 #1 (Debian))
	id 17kVzN-0006jM-00; Thu, 29 Aug 2002 15:34:01 -0500
Date: Thu, 29 Aug 2002 15:34:01 -0500 (CDT)
From: Adam Heath <doogie@debian.org>
X-X-Sender:  <adam@gradall.private.brainfood.com>
To: Adam Lackorzynski <adam@os.inf.tu-dresden.de>, 
     <153620-done@bugs.debian.org>
Subject: Re: Bug#153620: md5sum: MD5 file parser problems
In-Reply-To: <20020719220807.GA5773@os.inf.tu-dresden.de>
Message-ID: <Pine.LNX.4.33.0208291533160.6356-100000@gradall.private.brainfood.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Delivered-To: 153620-done@bugs.debian.org

On Sat, 20 Jul 2002, Adam Lackorzynski wrote:

> Trying to check signed MD5SUMS from cdimage.d.o gives me the following
> error:
>
> md5sum -vc MD5SUMS
> debian-22r7-alpha-binary-1.iso OK
> debian-22r7-alpha-binary-1_NONUS.iso OK
> debian-22r7-alpha-binary-2.iso       OK
> debian-22r7-alpha-binary-3.iso       OK
> debian-22r7-alpha-binan              md5sum: can't open debian-22r7-alpha-binan
> FAILED
> md5sum: 1 of 5 file(s) failed MD5 check

Not a bug.  Strip the sig first.

cdimage.d.o should use detatched sigs, like Release.




Reply to: