[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#143307: Suggested fix



On Thu, 16 May 2002, Ian Jackson wrote:

> I suggest you add
>     sincenothing= 0;
> to before the two returns near the top of deferred_remove in remove.c,
> ie just in between the two occurrences of these two lines:
>     pkg->clientdata->istobe= itb_normal;
>     return;
>
> You should probably add
>     sincenothing= 0;
> to inside the setjmp handler in while (queuelen) in
> packages.c:process_queue, too.

These don't make sense.  You are suggesting to reset the counter to the start
value, when there could be actual real errors that have been detected.

> Really, it would be better to do something different to arrange to
> definitely only increment sincenothing if the package is put back on
> the queue, rather than having to remember in all places where its
> processing is stopped *without* putting it back on the queue.

This is what I prefer, but don't have time think about it.



-- 
To UNSUBSCRIBE, email to debian-dpkg-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org



Reply to: