[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#46159: dpkg-dev:



Package: dpkg-dev
Version: 1.4.1.11

Hi Wichert!

I'm sorry, but there's still another bug in the new dpkg-source code :-(
It can't grok a totally empty diff file and complains about a missing
newline. (noticed with gcombust_0.1.24-1) It seems I simply haven't
thought of this case :-)

Below is a patch.

Roman

--- /usr/bin/dpkg-source	Fri Sep 24 03:27:42 1999
+++ dpkg-source	Tue Sep 28 09:42:20 1999
@@ -511,7 +511,7 @@
         &forkgzipread("$dscdir/$difffile");
         $/="\n";
 	$_ = <GZIP>;
-	do {
+	while ($_ || !eof(GZIP)) {
 	    # read file header (---/+++ pair)
 	    s/\n$// or &error("diff is missing trailing newline");
 	    /^--- / or &error("expected ^--- in line $. of diff");
@@ -553,7 +553,7 @@
 		}
 	    }
 	    $hunk or &error("expected ^\@\@ at line $. of diff");
-        } while ($_ || !eof(GZIP));
+        }
         close(GZIP);
         
         &reapgzip;


Reply to: