Bug#32318: dpkg-dev: dpkg-buildpackage doesn't stop on errors

[jdg@maths.qmw.ac.uk (Julian Gilbey)]

reassign 32318 dpkg-dev
retitle 32318 dpkg-dev: dpkg-buildpackage doesn't stop on errors
thanks

John Goerzen reported:
> For instance:
> 
> dh_installexamples
> cp: template.html: No such file or directory
> dh_installexamples: command returned error code
> make: *** [binary-indep] Error 1
>  signfile dailyupdate_6.01-1.dsc
> Pretty Good Privacy(tm) 2.6.3a - Public-key encryption for the masses.
> 
> Even after make aborts with error, debuild goes on to try to sign things.

It's actually a bug in these lines of dpkg-buildpackage:

withecho debian/rules build
withecho $rootcommand debian/rules $binarytarget
if [ x$binaryonly = x ]; then
        $signsource "$pv.dsc"
fi
chg=../"$pva.changes"
withecho dpkg-genchanges "$@" >"$chg"

Nowhere are there any checks for whether the commands succeeded.

   Julian

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

            Julian Gilbey             Email: J.D.Gilbey@qmw.ac.uk
       Dept of Mathematical Sciences, Queen Mary & Westfield College,
                  Mile End Road, London E1 4NS, ENGLAND
      -*- Finger jdg@goedel.maths.qmw.ac.uk for my PGP public key. -*-