[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#780318: marked as done (release-notes: the draft picture are always display, even in production mode)

Your message dated Tue, 17 Mar 2015 08:00:25 +0100
with message-id <5507D109.60004@thykier.net>
and subject line Re: Bug#780318: release-notes: the draft picture are always display, even in production mode
has caused the Debian Bug report #780318,
regarding release-notes: the draft picture are always display, even in production mode
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
780318: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=780318
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: release-notes
Severity: important
Tags: patch

The CSS used to add the Draft picture is in debian.css so the draft
style is added with or without the draft mode enabled. It will become
a problem when we will change it to production mode.

The attached patch move the CSS directives into a xsl conditional
block so the status of draft mode is used.

I removed the value of <xsl:param
name="draft.watermark.image">images/draft.png</xsl:param>
to a blank value because it does not need to be used now: the draft
picture is displayed in header and footer blocks.


The patch is based on the current SVN version (revision #10657).

-- 
Stéphane

Index: debian.css
===================================================================
--- debian.css	(révision 10657)
+++ debian.css	(copie de travail)
@@ -167,20 +167,6 @@
     opacity: 1;
 }
 
-.navheader, .navfooter {
-    background-image: url('images/draft.png');
-    background-repeat: no-repeat;
-    background-position: top left;
-}
-
-.navheader > table {
-    background-image: url('images/draft.png');
-}
-
-.navfooter > table {
-    background-image: url('images/draft.png');
-}
-
 @media (max-width: 5in), (max-device-width: 5in){
     .navfooter > table {
         font-size: 0;
Index: html.xsl
===================================================================
--- html.xsl	(révision 10657)
+++ html.xsl	(copie de travail)
@@ -7,7 +7,7 @@
   <xsl:param name="navig.graphics" select="1"/>
   <xsl:param name="navig.graphics.extension">.png</xsl:param>
   <xsl:param name="chunk.section.depth">0</xsl:param>
-  <xsl:param name="draft.watermark.image">images/draft.png</xsl:param>
+  <xsl:param name="draft.watermark.image"></xsl:param>
   <xsl:param name="html.stylesheet">debian.css</xsl:param>
   <xsl:param name="section.autolabel">1</xsl:param>
   <xsl:param name="section.label.includes.component.label">1</xsl:param>
@@ -27,6 +27,14 @@
         background-image: none;
       }
     </style>
+
+    <xsl:if test="($draft.mode = 'yes')">
+    <style type="text/css">
+        .navheader, .navfooter {
+            background-image: url('images/draft.png');
+        }
+    </style>
+    </xsl:if>
   </xsl:template>
 
   <xsl:template match="acronym">

--- End Message ---
--- Begin Message --- 
On 2015-03-12 01:14, Stéphane Blondon wrote:
> Package: release-notes
> Severity: important
> Tags: patch
> 
> The CSS used to add the Draft picture is in debian.css so the draft
> style is added with or without the draft mode enabled. It will become
> a problem when we will change it to production mode.
> 
> The attached patch move the CSS directives into a xsl conditional
> block so the status of draft mode is used.
> 
> I removed the value of <xsl:param
> name="draft.watermark.image">images/draft.png</xsl:param>
> to a blank value because it does not need to be used now: the draft
> picture is displayed in header and footer blocks.
> 
> 
> The patch is based on the current SVN version (revision #10657).
> 

Thanks for catching this! :)

I have applied the patch.

Thanks,
~Niels

--- End Message ---
Reply to: