[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#751112: [php-maint] Bug#751112: release-notes: [jessie] Document changes in PHP 5.4->5.5 upgrade



On 2015-01-15 10:38, Ondřej Surý wrote:
> Hi Niels,
> 
> On Thu, Jan 15, 2015, at 08:20, Niels Thykier wrote:
>> On 2015-01-15 00:52, Lior Kaplan wrote:
>>> [...]
>>> I think it would be worth to mention the JSON extension is now external (to
>>> php.net).
>>>
>>> Kaplan
>>>
>>
>> Can you please clarify that?  According to
>> http://php.net/manual/en/json.installation.php, the JSON extension seems
>> to be bundled with PHP itself since 5.2.0 with no "end" date/version
>> (unless Debian has compiled it out)?
> 
> The bundled json extension has JSON NO_EVIL licenses, so it had to be
> cut out and replaced by pecl-json-c extension.
> 
> We had some problems detangling circular dependencies, but it should be
> sorted out automatically and the extension is installed by default. I
> think right now the functionality is exact (or almost exact).
> 
> But Lion is right that it's probably worth mentioning it in release
> noted.
> 
> O.
> 

Ack, thanks.  I applied the following patch to document that JSON
change.  A(nother) review is appreciated. :)

Thanks,
~Niels


>From 928d23217f0025e02c440e962f6d3d5a264227cb Mon Sep 17 00:00:00 2001
From: nthykier <nthykier@313b444b-1b9f-4f58-a734-7bb04f332e8d>
Date: Tue, 20 Jan 2015 17:36:37 +0000
Subject: [PATCH] en/issues: PHP JSON implementation got swapped

Signed-off-by: Niels Thykier <niels@thykier.net>

git-svn-id: svn+ssh://svn.debian.org/svn/ddp/manuals/trunk/release-notes@10592 313b444b-1b9f-4f58-a734-7bb04f332e8d
---
 en/issues.dbk | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/en/issues.dbk b/en/issues.dbk
index b2522fe..bef2995 100644
--- a/en/issues.dbk
+++ b/en/issues.dbk
@@ -189,6 +189,15 @@ $ echo 'openssh-server openssh-server/permit-root-login boolean true' | debconf-
         cipher mode requires it.
       </para>
     </listitem>
+    <listitem>
+      <para>
+        For legal reasons, the JSON implementation bundled with PHP
+        has been replaced with the version provided by the "jsonc"
+        PECL module.  Code that makes assumptions (if any) about the
+        finer implementation details of the PHP JSON parser may need
+        to be reviewed.
+      </para>
+    </listitem>
   </itemizedlist>
   <para>
     For more information or the full list of potential issues, please
-- 
2.1.4


Reply to: