[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#480723: developers-reference: Please update section 5.11.6 (Acknowledging an NMU)



tags 480723 + patch
thanks

Francesco Namuri <francesco@namuri.it> writes:
> I propose the change of this part:
>
> "
> Once this is done, you have to close the bugs that have been tagged
> fixed by the NMU. The easiest way is to use the -v option of
> dpkg-buildpackage, as this allows you to include just all changes since
> your last maintainer upload. Alternatively, you can close them manually
> by sending the required mails to the BTS or by adding the required
> closes: #nnnn in the changelog entry of your next upload.
> "

Yep, this is wrong nowadays. I would propose to apply the following diff
to update this part:

Index: pkgs.dbk
===================================================================
--- pkgs.dbk	(revision 5203)
+++ pkgs.dbk	(working copy)
@@ -2016,13 +2016,12 @@
 <para>
 If one of your packages has been NMU'ed, you have to incorporate the changes in
 your copy of the sources.  This is easy, you just have to apply the patch that
-has been sent to you.  Once this is done, you have to close the bugs that have
-been tagged fixed by the NMU.  The easiest way is to use the
-<literal>-v</literal> option of <command>dpkg-buildpackage</command>, as this
-allows you to include just all changes since your last maintainer upload.
-Alternatively, you can close them manually by sending the required mails to the
-BTS or by adding the required <literal>closes: #nnnn</literal> in the changelog
-entry of your next upload.
+has been sent to you.  
+Once this is done, you have to check if the bug has been already closed
+by the author of the NMU. If this has been done, you just need to keep the
+changelog entry of the NMU in your <filename>debian/changelog</filename>.
+Should the bugs still be open, use the mail interface of the BTS to
+mark them closed in the version of the NMU.
 </para>
 <para>
 In any case, you should not be upset by the NMU.  An NMU is not a personal

Reasoning to drop the -v hint: It's wrong. If the bug has been closed in
the NMU version, the BTS should know about it. If the NMUer screwed
things up and didn't close the (right) bug, the maintainer should just
fix the versioning information, nothing more. Using -v as originally
described will close the bug with the next version of the maintainer
upload.

Marc
-- 
BOFH #435:
Internet shut down due to maintainance

Attachment: pgpswkbnAZQlv.pgp
Description: PGP signature


Reply to: