[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#351255: RFS: php-getid3: PHP4 script that extracts useful information from MP3s & other multimedia file formats



Package: developers-reference
Version: 3.3.7
Severity: minor

On Fri, Feb 03, 2006 at 01:23:24PM +0100, Romain Beauxis wrote:
> On Thu, 2 Feb 2006 23:49:42 -0500, Justin Pryzby wrote  
> > This could be priority: extra, unless something not in extra will  
> > depend on it.  
>  
> Well ,according to policy: 
> "extra  
>  This contains all packages that conflict with others with required, 
> important, standard or optional priorities, or are only likely to be useful 
> if you already know what they are or have specialized requirements." 
>  
> I don't see well why this should apply to this package.. 
Okay, up to you.  I think people often leave the default priority when
it could be bumped back, without really giving it any thought.

> > Build-Depends: @cdbs@  
> > I think this is RC and not allowed..  Build-Depends have to be  
> > available before the build starts, and mustn't be modified by   
> > standard targets: http://release.debian.org/etch_rc_policy.txt But I   
> > might be wrong, and it might be okay as written.  
>   
> Hum...  
> This is the meaning of this:  
> # In order to regenerate 'debian/control' :  
> #   DEB_AUTO_UPDATE_DEBIAN_CONTROL=yes fakeroot debian/rules clean  
> # Then check manually if everything's ok  
>   
> debian/control.in is only used when manualy invoking it, and never during a  
> buildd. This the way I did for other packages that are allready in the  
> archive, like linuxdcpp or mediawiki...  
Okay, then I guess it is okay.  Sorry for the confusion; I don't know
the first thing about cdbs (though it does make a nice short rules
file!).

> > ./debian/watch  
> > Please consider using the sf.net format now documented.  
> Done!  

Nope.  Check uscan.1; the sf.net format actually uses http://sf.net/,
and is rewritten internally by uscan.  I don't know if your method
would fail, but it is unintentional, and more ugly :)
For more info:
  http://lists.debian.org/debian-mentors/2005/12/msg00035.html

Also, your ./debian/dirs is now exactly one line long.  If I were
using a non-cdbs debhelper, I would remove the file, and put the dir
as an argument to dh_installdirs; but, I don't know if you can do that
with cdbs.

Since you "repackaged" the .orig tarball [0] (right?), could you make
it extract to ./php-getid3-1.7.5.orig/ instead, as documented in the
DevRef?

  [0] because upstream has a .zipball only
  [1] http://www.us.debian.org/doc/developers-reference/ch-best-pkging-practices.en.html#s-repackaged origtargz
      6.7.8.2; the anchor for this is broken; it has a space, which
      doesn't work for me as a +, thus the bug.  Probably hasn't been
      found before only because since the TOC doesn't link to it ..
      which IMO it should..

Justin


-- 
To UNSUBSCRIBE, email to debian-mentors-REQUEST@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org




Reply to: