On Thu, Nov 13, 2025 at 12:43:17AM +0100, Simon Josefsson wrote: > Bastien Roucaries <rouca@debian.org> writes: > > > Le mercredi 12 novembre 2025, 23:16:27 heure normale d’Europe centrale > > Simon Josefsson a écrit : > >> Package: wnpp > >> Severity: wishlist > >> Owner: Simon Josefsson <simon@josefsson.org> > >> > >> * Package name : golang-modernc-sqlite > >> Version : 1.40.0-1 > >> Upstream Author : The Sqlite Authors > >> * URL : https://gitlab.com/cznic/sqlite > >> * License : BSD-3-Clause > >> Programming Lang: Go > >> Description : CGo-free port of SQLite/SQLite3 (Go library) > >> > >> SQLite is an in-process implementation of a self-contained, > >> serverless, zero-configuration, transactional SQL database engine. > > are you sure the var __ccgo_ts1 is the prefered form of modification ? > > https://gitlab.com/cznic/sqlite/-/raw/master/lib/sqlite_linux_loong64.go > > > > ??? > > Thank you for review and feedback. > > To be honest, I haven't yet started the full-blown debian/copyright > review work, focusing on just getting packages to build. I have not > looked too closely at any source code in this package. > > Definitely we should not rely on generated code without confirming that > re-generating it (using tools in main) produces identical outputs. Do > you know what 'generator' is used here? I'll read upstream > documentation to learn more, and/or engage with upstream... I don't know much about the Go ecosystem, but from a quick look at https://gitlab.com/cznic/sqlite/-/blob/master/vendor_libsqlite3/main.go?ref_type=heads#L45 ...and also things like https://pkg.go.dev/modernc.org/libc ...it would seem that they use ccgo: https://pkg.go.dev/modernc.org/ccgo/v4#section-readme https://gitlab.com/cznic/ccgo G'luck, Peter -- Peter Pentchev roam@ringlet.net roam@debian.org peter@morpheusly.com PGP key: https://www.ringlet.net/roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13
Attachment:
signature.asc
Description: PGP signature