[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Let's make 2025 a year when code reviews became common in Debian



Hi Matthew!

> > Numerous people are posting Merge Requests on Salsa. Please help review them!
>
> I'd much much rather MRs were associated with bug reports; that way I
> only have to remember to check one place for outstanding issues in my
> packages, and years down the line when I wonder "why did this change get
> made" I can look up the bug report in the BTS.

Yes, for bugs that makes sense. Please note however that Merge
Requests is more than just patches/bug fixes. It is a general
mechanism to facilitate code reviews. It does not necessarily make
sense to publish every commit as a patch on bugs.debian.org before
committing it to the git repository. Also, in many cases it may be
most efficient to file at bugs.debian.org only the issue, and do the
actual code submission, testing, and re-submission as a Merge Request.

If you don't like using Salsa or don't like reviewing Merge Requests,
then this call is probably not for you. However, if you want Debian to
grow and you want to welcome new contributors, or in general work in a
collaborative way towards ending single-maintainer packages, reviewing
MRs posted by others a great way to help out.


Reply to: