Re: DEP-18: Git and GitLab usage in other Linux distros (Re: Representing Debian Metadata in Git)
On 11/10/24 3:42 AM, Otto Kekäläinen wrote:
[ Requiring two party sign-off on every change ]
> I wonder if it would make sense to organize some kind of "office
> hours" for code reviews and code testing best practices and
> guidance...
As someone working in a very large organization where this is required:
That's fine in a company setting. It is not in a volunteer setting,
unless you introduce very firm expectations about turnaround times. As
much as I would see the benefit of that, Debian with its highly
asynchronous work ethics is not that environment.
It is not a problem of best practices and guidance. It is one of
available time, motivation (spoons), and commitment. In a work place you
can demand that and if necessary, reassign to some other team member
whose job it is to review.
Insider risk concerns aside, maybe we should focus on making mistakes
easier to roll back. That is very heavyweight today. And that many
Debian services do not have appropriate staging environments is also a
problem - orthogonal to code review but related to testing practices.
Kind regards
Philipp Kern
Reply to: