[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: How to contribute ?



On 1/2/22 13:00, Andrey Rahmatullin wrote:
On Sun, Jan 02, 2022 at 11:07:10AM -0600, Zebediah Figura wrote:
vkd3d 1.2-6 in Experimental is not usable in Sid because it needs
mesa-vulkan-driver << 21.

Michael did that because vkd3d tests fails during building. I don't know
why because it fails with mesa 20 too.

I opened a bug report upstream and wine/vkd3d developer told me that there
is this issue because of nobody has the same GPU (someone can have the
error and someone else not)
The tests shouldn't access the GPU though so it shouldn't depend on actual
hardware.

Sorry, can you please clarify? libvkd3d is essentially a GPU driver (well,
translation layer), so its tests need to access the GPU or they're
meaningless.
OK, if the tests need access to actual hardware then they must be turned
off during the package build process.
(though of course tests for code that needs hardware don't necessarily
need hardware too)


Is there a codified set of guidelines for what a test can and can't do?
A build time test can do only what a package build process can do, which,
while I don't think this part is codified, certainly cannot rely on even
presence of specific hardware.


For what it's worth, we don't exactly rely on the presence of specific hardware. We run the tests with whatever GPU is available, and should skip them if none is.

There are test failures because of subtle differences in the hardware, or driver versions. Ideally our tests should pass on all hardware and drivers, but that's hard if not impossible to guarantee.

If it makes a difference I can provide a patch that will let the tests pass on Debian hardware.


Reply to: