[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: MBF: valgrind-if-available



On Sun, 2022-02-20 at 22:43 +0100, Adam Borowski wrote:
> On Sun, Feb 20, 2022 at 04:32:43PM -0500, Jeremy Bicha wrote:
> > On Sun, Feb 20, 2022 at 1:46 PM Adam Borowski <kilobyte@angband.pl> wrote:
> > > The correct answer currently is:
> > >     [amd64 arm64 armhf i386 mips64el mipsel ppc64el s390x powerpc ppc64]
> > > but it keeps changing, and you don't want to track it by hand if I can do
> > > that for you.
> > > 
> > > Thus: please [b-]depend on valgrind-if-available.
> 
> > Do you have any suggestions on how to handle this when the valgrind
> > test is set by a configure flag?
> 
> Is the configure flag required to enable valgrind tests?  If not, the very
> point of "configure" scripts is to auto-detect presence of tools.
> 
> > The way I've been handling it is to just keep a hard-coded list of
> > valgrind architectures in sync between my debian/control and
> > debian/rules.
> 
> if which valgrind >/dev/null; then

This should use "command -v", not which, I think?

Ben.

-- 
Ben Hutchings
Beware of programmers who carry screwdrivers. - Leonard Brandwein

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: