Re: chromium: Update to version 94.0.4606.61 (security-fixes)
On Sat, Feb 12, 2022 at 2:12 AM Andres Salomon <dilinger@queued.net> wrote:
>
> On 2/11/22 06:18, Roger Shimizu wrote:
>
> > Dear Andres,
> >
> > Thanks for your work for chromium!
> >
> > On Mon, Jan 3, 2022 at 7:33 PM Andres Salomon <dilinger@queued.net> wrote:
> >>>> I saw
> >>>> https://salsa.debian.org/dilinger/chromium/-/commit/5c05f430e192961527ec9a64bbaa64401dc14d95
> >>>> , but buster now also includes LLVM/clang 11 (it was introduced to
> >>>> support a more recent Rust toolchain needed for Firefox), so you
> >>>> might be reduce complexity here further:
> >>>> https://tracker.debian.org/pkg/llvm-toolchain-11
> >>>>
> >>>> It's in buster-proposed-updates since there hasn't been a point
> >>>> release since, but for the purposes of buster-security builds, it
> >>>> doesn't matter (they chroots have been modified to includen
> >>>> buster-proposed-updates temporarily):
> >>> Ah, very helpful, thanks! I'll give buster a try (just created
> >>> the 'v96-buster' branch). Between that and various backports, I think
> >>> we might be in good shape.
> >> Unfortunately it needs a newer nodejs than what's in buster, so I'll go
> >> back to focusing on bullseye & sid for now. :(
> > I tried to backport bullseye's v97 to buster, but error below occured.
> > I also tired the v96-buster branch from your salsa git repo, and got
> > similar error.
> >
> > So this is the error you mentioned above that buster's nodejs package
> > is too old for chromium?
> > Is it possible to use embed nodejs to workaround this issue?
> >
> > I also guess this might be related to incompatible between system's
> > nodejs and embed rollup binary.
> > Is it possible to add a patch to replace with system's rollup?
> >
> > Error from buster-backports pbuilder for bullseye's chromium v97:
> > ====
> > FAILED: gen/third_party/devtools-frontend/src/front_end/panels/timeline/components/components.js
> > python3 ../../third_party/node/node.py
> > ../../third_party/devtools-frontend/src/node_modules/rollup/dist/bin/rollup
> > --silent --config
> > ../../third_party/devtools-frontend/src/scripts/build/rollup.config.js
> > --input gen/third_party/devtools-frontend/src/front_end/panels/timeline/components/components.prebundle.js
> > --file gen/third_party/devtools-frontend/src/front_end/panels/timeline/components/components.js
> > --configDCHECK
> > Traceback (most recent call last):
> > File "../../third_party/node/node.py", line 36, in <module>
> > RunNode(sys.argv[1:])
> > File "../../third_party/node/node.py", line 31, in RunNode
> > raise RuntimeError('%s failed: %s' % (cmd, stderr))
> > RuntimeError: ['/usr/bin/nodejs',
> > '../../third_party/devtools-frontend/src/node_modules/rollup/dist/bin/rollup',
> > '--silent', '--config',
> > '../../third_party/devtools-frontend/src/scripts/build/rollup.config.js',
> > '--input', 'gen/third_party/devtools-frontend/src/front_end/panels/timeline/components/components.prebundle.js',
> > '--file', 'gen/third_party/devtools-frontend/src/front_end/panels/timeline/components/components.js',
> > '--configDCHECK'] failed: b'[!] (plugin minify-html-template-literals)
> > TypeError: result.matchAll is not a
> > function\ngen/third_party/devtools-frontend/src/front_end/panels/timeline/components/WebVitalsTimeline.js\nTypeError:
> > result.matchAll is not a function\n at Object.minifyHTML
> > (/build/chromium-97.0.4692.99/third_party/devtools-frontend/src/node_modules/minify-html-literals/src/strategy.ts:145:41)\n
> > at Object.minifyHTML
> > (/build/chromium-97.0.4692.99/third_party/devtools-frontend/src/scripts/build/rollup.config.js:80:37)\n
> > at templates.forEach.template
> > (/build/chromium-97.0.4692.99/third_party/devtools-frontend/src/node_modules/minify-html-literals/src/minifyHTMLLiterals.ts:322:24)\n
> > at Array.forEach (<anonymous>)\n at Object.minifyHTMLLiterals
> > (/build/chromium-97.0.4692.99/third_party/devtools-frontend/src/node_modules/minify-html-literals/src/minifyHTMLLiterals.ts:297:13)\n
> > at Object.transform
> > (/build/chromium-97.0.4692.99/third_party/devtools-frontend/src/node_modules/rollup-plugin-minify-html-template-literals/dist/index.js:15:47)\n
> > at Promise.resolve.then
> > (/build/chromium-97.0.4692.99/third_party/devtools-frontend/src/node_modules/rollup/dist/shared/rollup.js:20218:25)\n\n'
> > ====
> >
> > Cheers,
>
>
>
> Yes, that's the error. "String.matchAll is only available from Node.js
> 12.0 onwards", according to
> https://stackoverflow.com/questions/58558257/string-matchall-is-undefined
> , which also says that String.match is available. I didn't put any
> effort into working around it (either backporting a newer nodejs or
> replacing all String.matchAlls with something else), since I wanted to
> get chromium shipped for bullseye.
Thanks for your confirmation!
So we're on the same page.
I tried to backport nodejs 12 from bullseye to buster, but seems
nodejs 12 cannot coexist with nodejs 10, which means unless I backport
all the nodejs related packages, which has quite a long list ...
That's out of my capacity, so I give up.
> Unfortunately my chromium test builds are now breaking in sid due to
> another node (library, I think) change, so we're going to need to figure
> out something a bit more reliable with the node stuff. I'm not sure what
> that will look like yet. We're currently using the system rollup,
> although I think since there's multiple embedded node library copies, we
> might have an embedded rollup in there somewhere. I don't recall if my
> v96 branch used the system rollup or not, but I've merged everything
> into the chromium-team repo so you can use the bullseye branch from
> https://salsa.debian.org/chromium-team/chromium for testing this stuff.
> It has chromium 98.
I also tried v98 based tree, and result is the same, same build error as above.
My conclusion is that buster cannot get chromiium major version
updated easily (except flatpak way, of course).
Cheers,
--
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1
Reply to: