Re: Bug#995722: Not running tests because tests miss source code is not useful
On 10/11/21 11:20 AM, Yadd wrote:
> For now:
>
> $ cat tags/s/source-contains-prebuilt-javascript-object.tag
> Tag: source-contains-prebuilt-javascript-object
> Severity: pedantic
> Check: cruft
> Explanation: The source tarball contains a prebuilt (minified)
> JavaScript object.
> They are usually left by mistake when generating the tarball by not
> cleaning the source directory first. You may want to report this as
> an upstream bug, in case there is no sign that this was intended.
>
> Following this discussion, it should be a "Severity: error", shouldn't it?
No.
This lintian test produces lots of false positive. I'm not sure if it is
that one test, but for example, if a JS file has lines of more than 512
chars, Lintian believe it's a binary, when sometimes, having a 512+ char
line of code in JS is legitimate, or even cannot be avoided.
Also, if we just don't use the file (neither at build time or runtime),
it's kind of ok-ish to just leave it as-is (because it doesn't infringe
any copyright, and it takes some time to manage this). Of course it's
better to remove it from the source package if possible, but it is my
opinion that this is of "Severity: pedantic" ... :)
Cheers,
Thomas Goirand (zigo)
Reply to: