Re: DEB_BUILD_OPTIONS vs DEB_BUILD_PROFILES: What is right and what is wrong?

[Bastien ROUCARIES <roucaries.bastien@gmail.com>]

Hi,

On Sun, Jan 6, 2019 at 1:45 AM Axel Beckert <abe@debian.org> wrote:
>
> Hi,
>
> while trying to get the nocheck build profile working, I stumbled over
> some discrepancies between
>
> * Debian Policy §4.9.1,
> * dpkg-buildflags (behaviour + man page), and
> * lintian's long description of the tag
>   override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS.
>
> lintian recommends, e.g. at
> https://lintian.debian.org/tags/override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS.html:
>
> > The debian/rules file for this package has an override_dh_auto_test
> > target that does not appear to check DEB_BUILD_OPTIONS against
> > nocheck.
> >
> > As this check is not automatically performed by debhelper(1), the
> > specified testsuite is run regardless of another maintainer using the
> > nocheck build profile.
> >
> > Please add a check such as:
> >
> >      override_dh_auto_test:
> >      ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
> >              ./run-upstream-testsuite
> >      endif

I personnaly use:
ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS) $(DEB_BUILD_PROFILES))
             ./run-upstream-testsuite
endif

I believe it is policy compliant and burn proof...

Maybe a footnote on policy or debref ?

Bastien