[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#903815: ITP: pw -- A simple command-line password manager



Am 15.07.18 um 12:07 schrieb Dashamir Hoxha:
> All your assertions/assumptions are wrong.
> Either you did not look close enough to the code, or you are not
> an expert on bash scripting (bash is a bit cryptic and difficult
> to understand even for experts).

Hmm, do you have tried to validate your shell code?

https://www.shellcheck.net/

I just pasted
https://raw.githubusercontent.com/dashohoxha/pw/master/src/pw.sh into
and got quite a lot of problematic remarks.

Have you test cases to prevent things Philipp has raised?
The concerns Philipp mentioned are valid, creating safe shell code isn't
easy and writing correct syntax isn't enough.

Your ITP about password managing isn't the first of course, as far I can
remember the common sense was that using Bash or any other Shell isn't
the best choice for doing things like this.

-- 
Regards
Carsten Schoenert


Reply to: