Re: Fwd: can anyone review diaspora-installer?

[Brian May <brian@linuxpenguins.xyz>]

On 2017-04-06 15:47, Pirate Praveen wrote:

Sharing with wider debian community, hoping to get some support.

Current version in unstable does not have any RC bugs, but recent
changes in the package made release managers not happy with the quality
of the package and it was removed from testing. Now their justification
to not accept unblock request is lack of time to review it before
stretch release.

 

 

postrm has:

 

id -u diaspora && userdel -r diaspora

 

Where -r == delete all files in the user's home directory.

 

As per:

 

https://sources.debian.net/src/diaspora-installer/0.6.3.0%2Bdebian4/debian/diaspora-common.postrm/

 

This makes me very very nervous. You have no control over what changes might happen to the home directory. It might not be the directory you expect it to be.

 

Been there myself. https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=190427

 

Far safer to delete the files you need deleted yourself, and remove the "-r" option.