[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#848591: wanna-build: Only enable --deb-emulate-sbuild for non-backports builds



Package: buildd.debian.org
Tags: patch

On Sun, Dec 18, 2016 at 12:15:24PM +0100, Ondrej Novy wrote:
> 2016-12-18 11:38 GMT+01:00 Mattia Rizzolo <mattia@debian.org>:
> > afaik sbuild strips the alternatives while parsing the .dsc (or
> > d/control or whatever), before passing the information to the resolvers,
> > so even if you use another resolver for -bpo you still get the same
> > behaviour.
> 
> right:
> 
> https://buildd.debian.org/status/package.php?p=python-tornado&suite=jessie-backports
> https://anonscm.debian.org/cgit/python-modules/packages/python-tornado.git/tree/debian/control#n24
> 
> python-tornado build-depends on missing:
> - python3:arm64 (>= 3.5)
> 
> So jessie-backports buildd have this "bug" too.

On Sun, Dec 18, 2016 at 10:04:46AM -0500, James McCoy wrote:
> On Sun, Dec 18, 2016 at 02:26:09PM +0100, Ondrej Novy wrote:
> > Hi,
> > 
> > 2016-12-18 14:14 GMT+01:00 James McCoy <jamessan@debian.org>:
> > 
> >     Well, sbuild's man page documents that the aptitude resolver will check
> >     alternatives. If it doesn't in practice, that sounds like a bug.
> > 
> > 
> > you need to run sbuild with "--resolve-alternatives" or add same option in
> > sbuildrc. Imho bug in manpage.
> […]
> The python-tornado backport didn't even make it to the buildd, so the
> issue you're seeing is probably related to wanna-build.

I think the attached patch will help, but I wasn't sure how to actually
test it.

Cheers,
-- 
James
GPG Key: 4096R/91BF BF4D 6956 BD5D F7B7  2D23 DFE6 91AE 331B A3DB
>From 56e9530528835a0ee8eecd1a0093da2a60166b06 Mon Sep 17 00:00:00 2001
From: James McCoy <jamessan@debian.org>
Date: Sun, 18 Dec 2016 10:50:33 -0500
Subject: [PATCH] Only enable --deb-emulate-sbuild for non-backports builds

fbf59be7c5efcfbb6b991b06c9a4db148e331a4a unconditionally added
--deb-emulate-sbuild to @doseoptions, but this breaks detection of
available dependencies for backports builds.

Signed-off-by: James McCoy <jamessan@debian.org>
---
 bin/wanna-build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/bin/wanna-build b/bin/wanna-build
index a9e9b27..dcd7903 100755
--- a/bin/wanna-build
+++ b/bin/wanna-build
@@ -1756,7 +1756,8 @@ sub wb_dose_builddebcheck {
 
     my $args = shift;
     my $architecture=$args->{arch};
-    my @doseoptions = qw(--failures --explain --quiet --deb-emulate-sbuild);
+    my @doseoptions = qw(--failures --explain --quiet);
+    push @doseoptions, '--deb-emulate-sbuild' if $distribution !~ /backports/;
     my $packagefiles = $args->{pkgs};
     my $sourcesfile = $args->{src};
 
-- 
2.11.0


Reply to: