Re: Mass Bug Filing: Missing Build-Depends: graphviz
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
I think you are mistaken about a few things.
On Sun, Mar 20, 2016 at 06:04:55PM +0100, Santiago Vila wrote:
> The maintainer points out that the default value for HAVE_DOT is NO,
> so he's reluctant to add the build-dependency.
If the program can be used without it, it should not be a Depends. That's what
Recommends are for. Default values have nothing to do with it; Depends are for
things that will make the program unusable if they aren't present, Recommends
are for things that should almost always be installed with the program.
That also means that programs calling dot will need graphviz in their
Build-Depends, no matter what the default is.
> But this is inconsistent with having graphviz in the Suggests line for
> doxygen.
I agree that if it is the default, it should be Recommends, not Suggests. This
doesn't change anything for the problem you're describing, however.
> The disappoining moral for this is that nobody looks at their build logs...
I don't think that's disappointing at all! It means we have built a system
that will let us know when something is wrong. That means we don't need to
poll for errors, because they will be pushed to us. (I think porters are still
doing this manually at least some of the time; I think FTBFS bugs should be
reported automatically.)
In other words, my solution to this bug would be to make doxygen exit with an
error code when calling dot fails. Then make will fail, it's an FTBFS, it gets
fixed, and everyone is happy.
Thanks,
Bas
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
iQIcBAEBAgAGBQJW7vEqAAoJEJzRfVgHwHE6Gm4QAKAhBvdYk+2kTZ6SKTjgH/B0
4OIBO8nSOJe+O5yTB3AordZq2zZS1afM0oWB3JiVfa6l6Ka9dfC8f9TOlvW5xGnm
pj0OO7b7jrH5oK5XToqj3DvDphNKpNwWnHKbeBWlJY779SVBa50kdwnbtg77wa5k
ZBl1NWLFlFeRgjbG6BQpn1l50NyRLMzTumLFtF+rpZACAwoiH+bkJVDlu83lfM72
/B4WLl9G7wxnhwhtfs2PcvRaYF8EzGuNDizu2PbwCp31CKUszF4+0q9JiqHtTwmV
VIFxB31fSU/RpmEIxI086wStd/Rax+Cn8HfAyTY6/tIOVBCeHYnNajWZkVEcNsoj
srsaGpPEGJouGr/MLqQIk5n6LLsiERq4aha5WpmccmgkNCxTIUXZlU62J6y5DzlT
lDkG5NXkEuf1qsk9bUJQEAbvdCKfbX6mtlbibxtGlSpeZ6LwfsQ+M9MoX300kH84
UYHMovo6M9CHXLdxt9AJOVBJTbERXbKVysnrov2pVlZSZiPFu7M/haz6Um13Vsku
AlIpYRYpfTRiNZ/dg1Tf0AtnMkSIqhy1441Jj+Egpe9EXAs9GfWaYNOa1yZYm1d8
1Wcbh0NdzakVDNmTWuPg47bGt7IOGUcgM74DQuRLCWxcaOOnErs0nI7+3x3kZ+5/
77few9WmaB+ZHhDWb+Vv
=AU0O
-----END PGP SIGNATURE-----
Reply to: