[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: dpkg-source to automatically add a Testsuite field



Hey Guillem,

Guillem Jover [2014-07-06 18:35 +0200]:
> Given that dpkg-dev has recognized the Testsuite field for some time,
> I don't really see a reason for dpkg-source not to automatically add
> it to the generated .dsc with an “autopkgtest” value if there is a
> debian/tests/control file around, instead of requiring maintainers
> to remember to set it manually.

Absolutely. In fact this was even discussed back then, that's why
README.package-tests.rst says "Future versions of dpkg-source might
add this automatically when a ``debian/tests/control`` file is
present." I just forgot to file a dpkg wishlist bug for that.

> Reading the spec [S], it seems to me that the file can be empty, as
> it states “This is a file containing zero or more RFC822-style
> stanzas”, so the code cannot do any sanity check, like checking if
> the file contains one stanza with a Tests field. So it will only
> check for the file presence.

That seems fine. A file with zero will cause the result "SKIP no tests
in this package", which should be as expected.


> I've queued a patch doing exactly that for dpkg 1.17.11. If there's
> any known reservations with that, please speak up.

Yay, thanks!

Martin
-- 
Martin Pitt                        | http://www.piware.de
Ubuntu Developer (www.ubuntu.com)  | Debian Developer  (www.debian.org)


Reply to: