Re: Bug#727833: ITP: node-bytes -- Byte string parser and formatter - Node.js module
On 03/11/2013 00:56, Jean-Christophe Dubacq wrote:
> Le 27/10/2013 15:37, Jérémy Lal a écrit :
>> Package: wnpp
>> Severity: wishlist
>> Owner: "Jérémy Lal" <firstname.lastname@example.org>
>> * Package name : node-bytes
>> Version : 0.2.1
>> Upstream Author : TJ Holowaychuk <email@example.com>
>> * URL : https://github.com/visionmedia/bytes.js
>> * License : Expat
>> Description : Byte string parser and formatter - Node.js module
>> This module parses strings representing an amount of bytes, like
>> 1kb, 2mb, 1gb; and inversely converts positive integers to a readable
>> format representing an amount of bytes.
>> It is useful for parsing or writing log files.
> I have looked at the code, and it seems to me that, again, we introduce
> some code in debian that decide they can name the units any way they
> like (see http://en.wikipedia.org/wiki/Binary_prefix).
> They decide, for example, to use k, m and g prefixes for 2^10, 2^20 and
> 2^30, where usage should point to at least k, M and G and correct usage
> to Ki, Mi, Gi. They also call bytes 'b' (usage is more 'B').
> Of course, this is a library, it may be used to scan other (external)
> data, I understand this may be part of something bigger, but:
> 1. This is a bad habit
> 2. This is bad code
> 3. Seriously, one package for _18_ lines of code?
I agree the units are wrong and will fix it, and try to make
upstream fix it too.