Re: away_0.9.5+ds-0+nmu2_multi.changes ACCEPTED into unstable
Hello,
On 25 October 2013 07:23, Rene Engelhard <rene@debian.org> wrote:
> Hi,
>
> On Fri, Oct 25, 2013 at 01:18:18AM +0000, Debian FTP Masters wrote:
>> Changed-By: Andreas Moog <amoog@ubuntu.com
> [...]
>> away (0.9.5+ds-0+nmu2) unstable; urgency=low
>> .
>> * Non-maintainer upload
>> - d/p/01_fix_makefile: $LIBS need to come after $SRC while linking to
>> fix building with ld --as-needed (Closes: #634323)
>
> A NMU for a MINOR bug is NOT something which should be done.
> I quietly accepted the dbs one, but this is over the line.
>
I sponsored Andreas' patch as NMU, on my own initiative.
> It builds fine. When some distro bogusly introduces changes which make
> all kind of packages breask they can fix them up; but this is not a reason
> for NMUing it in Debian.
>
You mean Debian right? Cause --as-needed is a linker flag available in
Debian's default toolchain and there is a lot of ongoing work done to
enable it by default.
https://wiki.debian.org/ToolChain/DSOLinking#Only_link_with_needed_libraries
http://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ld-as-needed;users=debian-gcc@lists.debian.org
Bogus or not, it's an upstream linker option which reduces amount of
linked libraries, and overwhelming majority of well behaved packages
do build with --as-needed in ever increasing amount of distributions,
e.g. OpenSuse, Fedora, etc. It's not default in Debian toolchain, but
there are no good reasons why it shouldn't be. I understand that
"away" package did not even handle CFLAGS, CPPFLAGS, LDFLAGS, and
DESTDIR until last nmu, but why not improve a package or at least
reply to the bug report?
Regards,
Dmitrijs.
Reply to: