dpkg-source again broken wrt to 3.0 (quilt)???

[Norbert Preining <preining@logic.at>]

Hi everyone,

maybe its just me, but I cannot get the hang of that 3.0 (quilt)
and pre/post applying patches.

Recently I prepared a NMU for less to finally fix the missing xz(tar.xz)
support, added a new patch, but it is *impossible* for me to build
a package. Irrelevant wether the patches were applied beforehand
or not, dpkg-buildpackage always ends up in trying to apply them TWO
times, which of course does not work.

Here a terminal log:
$ dpkg-buildpackage -us -uc -rfakeroot 
dpkg-buildpackage: source package less
dpkg-buildpackage: source version 444-1.1
dpkg-buildpackage: source changed by Norbert Preining <preining@debian.org>
dpkg-buildpackage: host architecture amd64
 dpkg-source --before-build less-444
dpkg-source: info: using options from less-444/debian/source/options: --compression=bzip2 --compression-level=9
dpkg-source: info: patches are not applied, applying them now
dpkg-source: info: applying 01-434417-LESS_IS_MORE.patch
dpkg-source: info: applying less-support-xz.patch
 fakeroot debian/rules clean
dh_testdir
dh_testroot
rm -f build-stamp
# Add here commands to clean up after the build process.
[ ! -f Makefile ] || /usr/bin/make distclean
dh_clean
	rm -f debian/less.substvars
	rm -f debian/less.*.debhelper
	rm -rf debian/less/
	rm -f debian/*.debhelper.log
	rm -f debian/files
	find .  \( \( -type f -a \
	        \( -name '#*#' -o -name '.*~' -o -name '*~' -o -name DEADJOE \
		 -o -name '*.orig' -o -name '*.rej' -o -name '*.bak' \
		 -o -name '.*.orig' -o -name .*.rej -o -name '.SUMS' \
		 -o -name TAGS -o \( -path '*/.deps/*' -a -name '*.P' \) \
		\) -exec rm -f {} \; \) -o \
		\( -type d -a -name autom4te.cache -prune -exec rm -rf {} \; \) \)
	rm -f *-stamp
 dpkg-source -b less-444
dpkg-source: info: using options from less-444/debian/source/options: --compression=bzip2 --compression-level=9
dpkg-source: info: using source format `3.0 (quilt)'
dpkg-source: info: building less using existing ./less_444.orig.tar.bz2
patching file debian/lesspipe.1
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file debian/lesspipe.1.rej
patching file debian/lesspipe
Reversed (or previously applied) patch detected!  Skipping patch.
1 out of 1 hunk ignored -- saving rejects to file debian/lesspipe.rej
dpkg-source: error: LC_ALL=C patch -t -F 0 -N -p1 -u -V never -g0 -E -b -B .pc/less-support-xz.patch/ < less-444.orig.kWo0pm/debian/patches/less-support-xz.patch gave error exit status 1
dpkg-buildpackage: error: dpkg-source -b less-444 gave error exit status 2
$

Well. And if I do pre-apply the patches qith quilt push -a then the same
error happens.

So what is it that dpkg-buildpackage, dpkg-source, and all the quilt 3.0
stuff is soooo braindamaged????

I expect a package to build when I call dpkg-buildpackage, and if the
source format is so super-intelligent to breeak that, than there is
an error in the design.

So, let the flame war start again, or the enlightning procedure. I am open
to explanations.

Best wishes

Norbert
------------------------------------------------------------------------
Norbert Preining            preining@{jaist.ac.jp, logic.at, debian.org}
JAIST, Japan                                 TeX Live & Debian Developer
DSA: 0x09C5B094   fp: 14DF 2E6C 0307 BE6D AD76  A9C0 D2BF 4AA3 09C5 B094
------------------------------------------------------------------------
You're bound to be unhappy if you optimize everything.
 			--- Donald E. Knuth