[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#648286: ITP: r8168 -- Realtek r8168 device driver for Linux (DKMS version)

On Sun, 2011-11-13 at 15:08 +0100, Andreas Beckmann wrote:
> On 2011-11-12 19:04, Patrick Matthäi wrote:
> > @Andreas and Dmitry:
> > You may cooperate on packaging or decide, who wants to maintain it in
> > the future.
> I just revived my old ITP http://bugs.debian.org/642198
> and tried to put my things in a git repository:
> Only git://git.debian.org/~anbe-guest/r8168.git seems to work so far.
> > @Ben:
> > I still think this driver should be added as alternative driver to the
> > archive, until r8169 will do its job for the promoted PCIIDs correctly.
> One possible solution I see would be to upload r8168 to sid (or
> experimental) and add a severity=serious bug "r8168 should not enter
> testing - let's fix r8169 in the kernel instead" to prevent migration.
> Documentation should include detailed instructions how to properly
> report bugs for the in-kernel r8169 if it does not work (but r8168 does).
> Do I see it correctly that this driver is to be classified as non-free?
> The source code says "GPL2+", but 50% of the source lines is something like
>     mdio_write(tp, 0x1E, 0x0078);
> making this look very 'blobby'.

Those sequences are reconfiguring the PHY, but some of them also patch
the PHY firmware.  Compare with the in-tree version which uses
request_firmware() for the latter.


Ben Hutchings
Never attribute to conspiracy what can adequately be explained by stupidity.

Attachment: signature.asc
Description: This is a digitally signed message part

Reply to: