Re: 38

["Giacomo A. Catenazzi" <cate@debian.org>]

On 27.08.2010 08:30, Stanislav Maslovski wrote:
> On Fri, Aug 27, 2010 at 12:22:08AM +0200, posion bit wrote:
> > I've just started my love history again with squeeze.
> >
> > There are 38 unquoted $i in /etc in i386 installing base+laptop+standar
> >
> > There are 172 "$i" (maching without spaces around) 38 of them matches
> > whit spaces around (unquoted).
> >
> > Some are iteration numbers, some are directory, files, etc...
> >
> > I've not time neither humor, to fill such bugs or not bugs depending
> > on the situation.
> >
> > That has been my first command after login:
> >
> >      grep -R ' $i ' /etc/ | grep -viE '(binary|no such)'
> >
> > Just in case that some good person as time and humor (what I lack
> > today) to review it and file the bug if may be convenient.
>
> So, what is the problem with this? Both usages are legitimate (if one
> understands what she is doing, of course).

yes, and probably they are called with a controlled environment.
Anyway IMHO they should be improved:
- people copy codes, not realizing that changing context effects
  the security
- system files are usually taken as example (of good coding
  style/practice).

So I would *improve* them.

ciao
	cate