[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#575938: ITP: dh-autoreconf -- debhelper add-on to call autoreconf and clean up after the build

Am Mittwoch, den 31.03.2010, 15:45 +0200 schrieb Mehdi Dogguy:
> Julian Andres Klode wrote:
> > On Wed, Mar 31, 2010 at 03:13:14PM +0200, Mehdi Dogguy wrote:
> >> Paul Wise wrote:
> >>> On Wed, Mar 31, 2010 at 1:03 AM, Julian Andres Klode <jak@debian.org> wrote:
> >>>
> >>>>>   Description     : debhelper add-on to call autoreconf and clean up after the build
> >>>>>
> >>>>> Package: dh-autoreconf
> >>> I'd suggest just putting this into debhelper rather than making it a
> >>> separate package.
> >>>
> >> Is there any advantage to have it packaged?
> >>
> >> AIUI, you have to add a build-dependency anyway and change at least one
> >> line in the debian/rules to call dh-autoreconf. Well, that line could
> >> simply call autoreconf (or whatever) which even makes debian/rules clearer.
> > 
> > The difference is that dh_autoreconf calls autoreconf and stores a list
> > of the changes and the changed files are then removed in the clean
> > target. If you just call autoreconf, the changes end up in the diff;
> > and this is not what we want.
> > 
> I do use autoreconf and I don't have these changes in my diff.
> IMO, a backup/restore script (where you specify the list of files to
> backup) may be more useful. It would be called before build and when cleaning.

I prefer the removal over the restoring the old files. You remove .o
files on clean, so why not remove the other auto-generated files on

Benjamin Drung
Ubuntu Developer (www.ubuntu.com) | Debian Maintainer (www.debian.org)

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

Reply to: