Re: Bug#466550: Pristine source from upstream VCS repository
On Fri, Mar 06, 2009 at 11:03:57AM +1100, Ben Finney wrote:
> === modified file 'policy.sgml'
> --- policy.sgml 2009-03-05 08:44:48 +0000
> +++ policy.sgml 2009-03-05 23:59:38 +0000
> @@ -1907,12 +1907,21 @@
> <tag><tt>get-orig-source</tt> (optional)</tag>
> <item>
> <p>
> - This target fetches the most recent version of the
> - original source package from a canonical archive site
> - (via FTP or WWW, for example), does any necessary
> + This target generates the original source archive for
> + the package, such that its contents exactly match the
> + original source archive used to generate the package
> + for Debian. See the “Original source archive”
> + section, below, for policy details of this file.
> + </p>
Surely, given that this is sgml, you should be referencing "Original source
archive" by id instead of "see below"?
> +
> + <p>
> + The actions for this target fetch the original source
> + package, corresponding to the Debian package version,
This reads wrong. What are "actions for this target"? Should be "This
target fetches [...]" as in the original, or "The target fetches [...]" if
you're trying to avoid repetition.
> <p>
> @@ -1922,8 +1931,14 @@
> </p>
>
> <p>
> - This target is optional, but providing it if
> - possible is a good idea.
> + This target is <em>optional</em>. A common reason to
> + forego this target is that the upstream developers
> + make canonical original source archive files for
> + specific versions available for direct public
> + download; in these cases, the package only needs an
> + appropriate <file>debian/watch</file> configuration
> + for <prgn>uscan</prgn> to fetch the original source
> + archive.
> </p>
> </item>
Why is 'optional' emphasized?
I don't like the speculation about developers' reasons for forgoing (not
'foregoing', btw) the target. I think this is better:
This target is optional. In many cases it is not needed because the
upstream developers make canonical original source archive files for each
version available for direct public download; in this case, creating a
<file>debian/watch</file> configuration that tells <prgn>uscan</prgn> how
to download the original source archive is sufficient.
I also wonder if this ought to be a footnote instead. I don't think uscan
should be considered normative in policy.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slangasek@ubuntu.com vorlon@debian.org
Reply to: