On 11/05/2009 04:44 PM, Raphael Hertzog wrote: > It has an implicit meaning of approval yes. If the review was negative, it > should not be added or it should be clarified in the Description what the > reviewer's comments were (always a good idea). > > Proposition of patches welcome. Please search the debian-devel archives > for the discussion about the rename. It was in june IIRC. Signed-off-by > has precisely been dismissed because it doesn's have this approval > connotation. This appears to be the reason: http://lists.debian.org/debian-devel/2009/06/msg00459.html the implication is that people "signing off" on a patch haven't necessarily read the code directly, but are approving it. I assume the goal is to imply both "i've read it" and "i approve it" with a single header, right? Since i know of no single word for this, i'd be fine with explicitly stating that is the intent in DEP-3 description of the Reviewed-By field, with just: s/reviewed by someone/reviewed and approved by someone/ --dkg
Attachment:
signature.asc
Description: OpenPGP digital signature