Re: Proposed mass bug filing: Perl 5.10.1 breaks 'make install PREFIX=$(TMP)/usr'
On Mon, Sep 14, 2009 at 11:39:40AM +0200, Marco d'Itri wrote:
> On Sep 13, Niko Tyni <ntyni@debian.org> wrote:
>
> > 246 packages failed to build with 'Error 13' at the end of the log,
> It's a big number. Can you add a temporary workaround for a few
> months until most packages are fixed?
Uh, it turns out I can indeed.
The upstream bug made me believe this was an intentional upstream change
without looking into it properly. Actually it's a Debian change we've
apparently been carrying since 2001 (perl 5.6.0-12). I accidentally
dropped the patch when handling 5.10.1 merge conflicts. How embarrassing.
I'll reinstate the change for 5.10.1-2 (patch attached for reference),
but in the long term we clearly should get rid of this and make all the
packages use DESTDIR (which was added in 2002). A lintian check should
be easy to implement, I'll look at that.
So, forget about the mass bug filing and sorry for the noise.
--
Niko Tyni ntyni@debian.org
>From 5d783c396b6900ae049a3d0c4af1099813dcb222 Mon Sep 17 00:00:00 2001
From: Niko Tyni <ntyni@debian.org>
Date: Tue, 15 Sep 2009 08:12:18 +0300
Subject: [PATCH] reinstate Debian change to ExtUtils::MakeMaker for now to allow overriding PREFIX at installation time again. (Closes: #545904)
---
lib/ExtUtils/MM_Unix.pm | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/lib/ExtUtils/MM_Unix.pm b/lib/ExtUtils/MM_Unix.pm
index 33a27ff..c3504b6 100644
--- a/lib/ExtUtils/MM_Unix.pm
+++ b/lib/ExtUtils/MM_Unix.pm
@@ -2963,8 +2963,7 @@ sub prefixify {
print STDERR " prefixify $var => $path\n" if $Verbose >= 2;
print STDERR " from $sprefix to $rprefix\n" if $Verbose >= 2;
- if( $self->{ARGS}{PREFIX} &&
- $path !~ s{^\Q$sprefix\E\b}{$rprefix}s )
+ if( $path !~ s{^\Q$sprefix\E\b}{$rprefix}s && $self->{ARGS}{PREFIX} )
{
print STDERR " cannot prefix, using default.\n" if $Verbose >= 2;
--
1.6.3.3
Reply to: