[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Rejuvenated kernel-package uploaded to unstable, please test



On Tue, Oct 14 2008, Paul Wise wrote:

> On Tue, Oct 14, 2008 at 12:23 PM, Frans Pop <elendil@planet.nl> wrote:
>
>> Problem is that even though this may avoid package conflicts, it is *not*
>> correct given the way Debian currently looks for firmware. Also, it is
>> not the way upstream recommends to install firmware.
>>
>> All (non-free) Debian firmware packages install the firmware files
>> directly under /lib/firmware, not /lib/firmware/$kernel-version.
>>
>> And Debian's udev does not consider the kernel-version when looking for
>> firmware. /lib/udev/hotplug.functions has:
>> FIRMWARE_DIRS='/lib/firmware /usr/local/lib/firmware /usr/lib/hotplug/firmware'
>
> In contrast, the latest upstream udev (130) has this:
>
> FIRMWARE_DIRS="/lib/firmware/$(uname -r) /lib/firmware"

        Seems like rpm spec files are likely to be changed as well.

        manoj

--- Begin Message ---
[Евгений Маначкин - Wed, Oct 15, 2008 at 11:54:34PM +0700]
| This is OK ?
| 
| --- linux-2.6.27/scripts/package/mkspec.orig    2008-10-11 00:00:38.000000000 +0700
| +++ linux-2.6.27/scripts/package/mkspec 2008-10-11 00:39:43.000000000 +0700
| @@ -64,8 +64,10 @@ fi
|  echo "%install"
|  echo "%ifarch ia64"
|  echo 'mkdir -p $RPM_BUILD_ROOT/boot/efi $RPM_BUILD_ROOT/lib/modules'
| +echo 'mkdir -p $RPM_BUILD_ROOT/boot/efi $RPM_BUILD_ROOT/lib/firmware'
|  echo "%else"
|  echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib/modules'
| +echo 'mkdir -p $RPM_BUILD_ROOT/boot $RPM_BUILD_ROOT/lib/firmware'
|  echo "%endif"
| 
|  echo 'INSTALL_MOD_PATH=$RPM_BUILD_ROOT make %{_smp_mflags} modules_install'
| @@ -92,5 +94,6 @@ echo "%files"
|  echo '%defattr (-, root, root)'
|  echo "%dir /lib/modules"
|  echo "/lib/modules/$KERNELRELEASE"
| +echo "/lib/firmware"
|  echo "/boot/*"
|  echo ""
| 

Evgeniy, it should be something like that

---
From: Evgeniy Manachkin <sfstudio@mail.ru>
Subject: [PATCH] mkspec - fix build rpm

Patch description goes here

Signed-off-by: Evgeniy Manachkin <sfstudio@mail.ru>
---
Patch body goes here

I didn't check the patch just show you the form of patch submission.
For example -- take a look on

	http://lkml.org/lkml/2008/10/15/2
or
	http://lkml.org/lkml/2008/10/15/20

Actually SubmittingPatches has a quite good description how to
make it right :)

		- Cyrill -

--- End Message ---

-- 
Date: 23 Feb 90 19:04:55 GMT From: merlyn@iwarp.intel.com (Randal
Schwartz) $,=' ';print grep(s/^.//, sort
"2another","4hacker,","1Just","3Perl");
Manoj Srivastava <srivasta@debian.org> <http://www.debian.org/~srivasta/>  
1024D/BF24424C print 4966 F272 D093 B493 410B  924B 21BA DABB BF24 424C

Reply to: