[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: divergence from upstream as a bug



On Sunday 18 May 2008, Bernd Eckenfels wrote:
> In article <87r6bzbt6l.fsf@frosties.localdomain> you wrote:
> > The diff.gz contains all the changes including the debian dir. It is
> > by no means obvious if there are patches in there or not.
>
> I think reading a debian diff is the every day job of DD and DAs. And all
> of them learned to search for +++ and ignore debian/.

Well we can still have debian/patches/$diff easily extracted and separated, 
even without orig.tar.gz, since these are purely new files to be created by 
patch: zcat *.diff.gz | patch -p1 (--force for hooligan diff.gz who touch 
outside debian/ when applied, no debian/patches/ obviously)

> However I do agree, extractin that to a web repository would be nice, to
> make it linkable.

Well I guess it is no too much hassle for p.d.o to inspect the diff.gz's and 
publish the results without even unpacking orig.tar.gz in the following way 
(or similar):

Checks:

1) get the debian/patches/ directory ( if any ): 
zcat $diff.gz | patch -p1 --force   
2) perl regex to see if upstream code is touched outside debian/patches/:
while ( <$diff_handler> ) { print $_ if ( /^---\s[^\/]+(?!\/debian)\// ); }
/* could be better ? */

Conclusions:

* run 1) and if debian/patches/ doesn't exists 
* and 2) returns no matches 
=> $SUMMARY - no patches applied by Debian, nothing to publish

* run 1) and if debian/patches/ exists
* run 2) returns no matches
=> $SUMMARY - patched by debian/patches
=> $PATCHES/ - publish them as well

* run 1) and if debian/patches/ doesn't exists
* run 2) returns matches
=> $SUMMARY - not very cool, patched in a combined fashion, good luck 
inspecting diff.gz youself
=> $PATCHES/ - no useful bits to reveal

* run 1) and if debian/patches/ exists 
* and 2) returns matches 
=> $SUMMARY - too bad, patches applied both ways (inside/outside 
combination) - by debian/patches and in a combine fashion, good luck 
inspecting diff.gz youself
=> $PATCHES/ - no useful bits to publish



I'm not certain about url's, but:

p.d.o/$debian_source_package_name/$SUMMARY
p.d.o/$debian_source_package_name/$PATCHES/

would suffice.


-- 
pub 4096R/0E4BD0AB 2003-03-18 <people.fccf.net/danchev/key pgp.mit.edu>
fingerprint 1AE7 7C66 0A26 5BFF DF22 5D55 1C57 0C89 0E4B D0AB 


Reply to: