On Mon, 2007-09-24 at 08:40 +1000, Hamish Moffatt wrote: > On Sun, Sep 23, 2007 at 11:37:39PM +0100, Ben Hutchings wrote: > > I wrote: > > > Package: rt2500-source > > > Version: 1:1.1.0-b4-4 > > > Severity: serious > > > > > > -----BEGIN PGP SIGNED MESSAGE----- > > > Hash: SHA1 > > > > > > rt2500-source includes a bzipped tarball which must be unpacked in > > > order to build modules from it. Therefore it should depend on bzip2. > > <snip> > > > > In fact this applies to any module source package, since > > module-assistant requires module source to be compressed with bzip2, not > > gzip. > > Really? nvidia-kernel-source is a .tar.gz here. Sorry, I looked in /usr/bin/module-assistant and could only see a "tar jxf" there, but now I realise that's for kernel tarballs. Module tarballs are handled by /usr/share/modass/packages/generic.sh which does indeed support gzip and bzip2 decompression. > > I'm not sure whether I should fix this bug in rt2500 and the other > > Ralink driver packages, or whether module-assistant should be changed to > > depend on bzip2 (or to install it along with build-essential). > > I wouldn't expect rt2500-source to depend on bzip2 any more than I > expect any package providing a PDF file to depend on a viewer. That's different because there are many PDF viewers (and other tools that work on PDFs). There's nothing much that can be done with a bzip2 archive without using bzip2. > However, tools that use those files definitely have a dependency ie > module-assistant. Ben. -- Ben Hutchings friends: People who know you well, but like you anyway.
Attachment:
signature.asc
Description: This is a digitally signed message part