Le samedi 09 décembre 2006 à 12:12 +0100, Andreas Barth a écrit : > Joss, one question: > You wrote in your changelog entry some time ago: > libpng (1.2.8rel-5) unstable; urgency=low > > * drop_pass_width.patch: don't export png_pass_width, it's absolutely > unnecessary. > > -- Josselin Mouette <joss@debian.org> Mon, 3 Oct 2005 20:18:43 +0200 > > Why was it unnecessary to export it, and why did packages FTBFS because > of that (cf http://bugs.debian.org/399499)? Or did I miss something? This symbol was added by enabling the assembly code, and at that moment vorlon asked me to unexport it. It looked safe at that moment, and packages didn't start to FTBFS because of the removal. The FTBFS bugs appearing probably mean that the patch needed to be updated. As the #ifdef PNG_HAVE_ASSEMBLER_COMBINE_ROW was replaced by #ifdef PNG_USE_PNGGCCRD, the logic around it has changed. The declaration probably needs to be moved directly to the C file using it so that it is not accessible to the application compiling against libpng. Furthermore, re-enabling this patch will not necessarily be enough to go back on the shlibs. I'm not 100% sure, but IIRC new symbols were added in 1.2.9, and maybe also in later versions. -- Josselin Mouette /\./\ "Do you have any more insane proposals for me?"
Attachment:
signature.asc
Description: Ceci est une partie de message =?ISO-8859-1?Q?num=E9riquement?= =?ISO-8859-1?Q?_sign=E9e?=