Re: Accepted grep 2.5.1.ds2-1 (source i386 sparc)
Hello,
On Tue, Sep 27, 2005 at 11:12:07AM +1000, Aníbal Monsalve Salazar wrote:
> On Mon, Sep 26, 2005 at 08:04:24PM +0200, Adeodato Simó wrote:
> >found 181378 2.5.1.ds2-1
> >thanks
> >
> >* Anibal Monsalve Salazar [Mon, 26 Sep 2005 05:47:06 -0700]:
> >
> >> * Removed 64-egf-speedup.patch, 65-dfa-optional.patch,
> >> 66-match_icase.patch and 67-w.patch from debian/patches,
> >> closes: #329876.
> >
> > Those patches fixed a bug (and two merged) that had been opened for 2
> > and a half years. I think it'd be useful if you tried to contact the
> > authors of the patches, and try to fix them instead of removing them?
>
> Sure, the grep maintainers decided to pull out them and will go
> trough the patches again.
I wondered if I introduced this issue while porting the Fedora patches to
Debian, so I tried Fedora's grep...which has the same issue.
You can reproduce it with this simple command:
echo foobar | grep -Fw ""
This was introduced by the patch I named '64-egf-speedup.patch'
You can fix it by changing the 'while (1)' by 'while (len)' (or by
embedding this while loop in a 'if (len){...}', I don't know if there is a
real difference, and what is the best way).
Tim Waugh, who wrote the original patches, may have a better understanding
of the grep's code.
The testsuite still pass with this patch.
BTW, I don't know if you received a mail I sent to grep@packages.debian.org,
which indicated that the additional patches (which I submitted because
they helped passing the testsuite) were fixing: #209194 #218873 #226397
#238167
If you plan to re-introduce these patches, please tell me. While checking
for this issue (#329876), I've seen that there was one issue fixed in a
Fedora update, related to this patch:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=161700
I can update 64-egf-speedup.patch if you want.
Kind Regards,
--
Nekral
Reply to: