Re: Accepted devfsd 1.3.25-14 (i386 source)

[Thierry Vignaud <tvignaud@mandrakesoft.com>]

Russell Coker <russell@coker.com.au> writes:

> Description: 
>  devfsd     - Daemon for the device filesystem
> Changes: 
>  devfsd (1.3.25-14) unstable; urgency=medium
>  .
>    * Fixed a bug in creating compatability links for DAC960 devices.

you did:

diff -u devfsd-1.3.25/devfsd.c devfsd-1.3.25/devfsd.c
--- devfsd-1.3.25/devfsd.c
+++ devfsd-1.3.25/devfsd.c
@@ -1504,8 +1504,7 @@
       case AC_RMOLDCOMPAT:
    compat_name = get_old_name (info->devname, info->namelen, compat_buf,
                    info->major, info->minor);
-   if ( (strncmp (info->devname, "rd/", 3) == 0) &&
-         (strncmp (ptr = (strrchr (info->devname, '/') +1), "part", 4) == 0) )
+   if ( strncmp (info->devname, "rd/", 3) == 0 )
            dest_name = info->devname+3;
    if ( (strncmp (info->devname, "ida/", 4) == 0) &&
          (strncmp (ptr = (strrchr (info->devname, '/') +1), "part

tested fix i uploaded on april 24 was:

--- ./devfsd.c.cdrom    2002-03-25 07:59:40.000000000 +0100
+++ ./devfsd.c  2002-08-17 18:06:17.000000000 +0200
@@ -1462,5 +1462,9 @@
       case AC_RMOLDCOMPAT:
    compat_name = get_old_name (info->devname, info->namelen, compat_buf,
                    info->major, info->minor);
+   if ( (strncmp (info->devname, "rd/", 3) == 0) &&
+         ((strncmp (ptr = (strrchr (info->devname, '/') +1), "part", 4) == 0) ||
+          (strncmp (ptr = (strrchr (info->devname, '/') +1), "disc", 4) == 0)))
+           dest_name = info->devname+3;
    if ( strncmp (info->devname, "ida/", 4) == 0) {
        ptr = (strrchr (info->devname, '/') +1);
        if ( (strncmp (ptr, "part", 4) == 0) || (strncmp (ptr, "disc", 4) == 0) ) {


dac9660 driver is not supposed to create other entries but who know...

btw, you really should resync with us as for devfsd patches (see
http://cvs.mandrakesoft.com/cgi-bin/cvsweb.cgi/SPECS/devfsd/)


since you took some of our patches (mid september 2002), we fix some
more bugs here:

- minilogd/devfsd races

- /dev/hd* managment (immediate effect is that root cannot access IDE
  cdrom under /dev/hdc if logging in on the console immediately after
  startup before any other user has yet log in. Obviously, for normal
  users pam_console_apply triggers ide-cd loading but for root it is
  never loaded)

- more support for cciss compatibility links

- no spurious ida/ in ida device paths

- ...