Re: Maintaining kernel source in sarge
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On Sunday 25 May 2003 06:19, Christoph Hellwig wrote:
> On Sun, May 25, 2003 at 01:51:05AM +0200, Arnd Bergmann wrote:
> > As a real-world example, kernel-patch-s390 can provide
> > the ptrace bug fix from Martin Schwidefsky, while
> > kernel-patch-debian contains the generic solution from Alan Cox.
>
> This sounds like a really bad idea (okay, not worse than the
> current situation but still bad). Martin should diff his patch ontop
> of Alan, if it has other core changes he should really post it to
> lkml and explain those. Now this unfortunately hasn't happend and
> if it has incompatible core changes (I haven't checked) that's one
> of those rare cases where you want to appy a patch condtionally.
Martins patch only has one additional change for s390 specific code
and he published both this diff alone as well as the combined patch.
The trouble was that the sid kernel-source included Alan's patch
while the woody kernel-source didn't (it does now), so now you
could no longer use kernel-patch-s390 from one tree for the other.
> > When building kernel-image-s390, make-kpkg would first apply
> > the arch specific patches and the the arch independent ones that
> > have not been superceded by an arch specific one.
>
> Again that's a very bad idea. Arch-independent patches should
> _always_ be applied before Arch-dependent ones, otherwiese applying
> MI patches will get absolute horror.
Ok, but I still would love to see single patches instead of one big
patch containing all the common stuff. You can't really avoid
situations where you want a patch on all architectures except one or
two. This may be either because a patch breaks on one architecture
(which should be of course be fixed, but you might not want to
rebuild all kernels and modules on all other architectures because of
it), or because the same fix is contained both in the debian collection
and in the patch set published by the upstream arch kernel maintainer.
I'm not sure if dh-kpatches already solves this problem, but it should
be possible to add.
Arnd <><
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (GNU/Linux)
iD8DBQE+0Lhs5t5GS2LDRf4RAkuFAJ4o2XdC1rVcnW/Bp0S4AMaB8ZQm4wCgpWuc
hDExBmIDeANBbt/jVWmlthw=
=j3ZW
-----END PGP SIGNATURE-----
Reply to: