[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: dbs package - should I upload it?

>>>>> "Martin" == Martin Bialasinski <martin@internet-treff.uni-koeln.de> writes:

    Martin> * Brian May <bam@debian.org> wrote: Hi,

    >> Technote: dbs-edit-patch extracts all patches before 021_debian
    >> into /tmp/021_debian/heimdal-0.3d, copies the result to
    >> /tmp/021_debian/heimdal-0.3d-old, and applies the last patch
    >> 021_debian (if it exists). Also, it creates a shell archive
    >> which will create the diff between the old and new directories:

    Martin> Why do you make a new 021_ diff from

    Martin> source + 001_ - 020_ to source + 001_ - 020_ + changes for
    Martin> 021_

    Martin> instead of

    Martin> source to source + changes for 021_ ?

Because under some circumstances, the diff for 021_ will be dependent
on the diff for 001_ to 020_.

While this should be avoided whenever possible, sometimes it is not
possible. For example consider diffs to automake generated files,
which require knowledge of changes to Makefile.am, for instance.

While care still needs to be taken (eg. editing 021_ could potentially
mess up 022_), I think this way is safest, because editing 021_ will
never cause conflict with an already existing 020_.

However, I imagine that there will be good arguments to do it the
other way too... Perhaps another command line option?
Brian May <bam@debian.org>

Reply to: