[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: intent to package countrycodes

On Sun 03 Sep 2000, Dr. Guenter Bechly wrote:

> I intend to package Country Codes 1.0.3, a text-based ISO3166 country code
> finder (yes, I know there is a Perl module that does the same, but this
> little tool is easier and more flexible). The package is actually already made 
> and lintian clean. It can be downloaded from http://www.bechly.de/debian/.

I've had a quick look.

The orig.tar.gz is 17k, and the diff.gz is 15k ?!
I see you have all the debian/*.ex files that the helper make script
creates; removing those will help greatly in reducing the size of
the diff; they are examples after all, and if you haven't used those
examples, there's not much point in leaving them in the diff (save
them somewhere else if you want to refer to them at a later stage).

I also see lines such as:

--- countrycodes-1.0.3.orig/common.c
+++ countrycodes-1.0.3/common.c
@@ -0,0 +1,62 @@

in your diff, meaning the diff is creating those files completely.
If there wasn't any source, only data, in the orig.tar.gz, then
perhaps you should make two packages: one with the data, and one
with the (your) software. However, I see:

--- countrycodes-1.0.3.orig/iso3166.c
+++ countrycodes-1.0.3/iso3166.c
@@ -0,0 +1,631 @@
+   ISO 3166 Country Codes program
+   --------------------------------------------------------------------
+   Country Codes
+   Copyright (C) 1999, 2000 Diego Javier Grigna <diego@grigna.com>

This means a file of 631 lines is created by your diff, with someone
else's copyright. So, I'm guessing the package copies (or links?)
source files from a subdir to the top dir. In that case, the "clean"
target in debian/rules should undo those actions so that the diff
is as small as possible.

Until these basic packaging paradigms are mastered, I don't think
this package is fit for uploading yet. Perhaps you should ask for
more help in debian-mentors (which is for helping new maintainers)?

Good luck,
Paul Slootman
home:       paul@wurtel.demon.nl http://www.wurtel.demon.nl/
work:       paul@murphy.nl       http://www.murphy.nl/
debian:     paul@debian.org      http://www.debian.org/
isdn4linux: paul@isdn4linux.de   http://www.isdn4linux.de/

To UNSUBSCRIBE, email to debian-devel-request@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmaster@lists.debian.org

Reply to: