Re: 14 days till bug horizon

[Tomasz Wegrzanowski <maniek@beer.com>]

On Mon, Mar 13, 2000 at 07:33:14AM -0800, Joseph Carter wrote:
> You know Tomasz, it would help if you had the slightest clue what you
> wrote about BEFORE you started claiming to have the solution.  Had you
> bothered to read the developer documentation you might have tried this:

Forget everything I previously said.
I made patches and missed when diff file was overwriten.
Herewith is correct patch.

> The problem is an arch-specific issue which does not affect i386 build or
> operation of the package.  I have not had time to try and figure out
> what's wrong with it (now).  This package has had no end of issues,
> usually regarding endianness independence which it claims to support (but
> I claim it supports very badly in most versions..)
> 
> Sometime this week I will see if a new upstream exists and maybe if I'm
> lucky it fixes the problem.

Not any endianness, but libsidplay support.
There were 2 typos in code supporting libsidplay,
that were out'ifdef'ed if you had no such lib installed
while configure'ing. It happened that on autobuild machine
libsidplay was installed, so code with typos were included,
so dpkg-buildpackage failed.

diff -ur mp3blaster-2-0b16.orig/src/sidplayer.cc mp3blaster-2-0b16/src/sidplayer.cc
--- mp3blaster-2-0b16.orig/src/sidplayer.cc	Mon Dec 13 02:23:04 1999
+++ mp3blaster-2-0b16/src/sidplayer.cc	Mon Mar 13 17:22:27 2000
@@ -27,7 +27,7 @@
 #include "playwindow.h"
 #include "sidplayer.h"
 
-extern struct _globalopts globalopts /* from main.cc */
+extern struct _globalopts globalopts; /* from main.cc */
 
 // SIDPlayer constructor
 SIDPlayer::SIDPlayer(mp3Play *calling, playWindow *interface, int threads)
diff -ur mp3blaster-2-0b16.orig/src/sidplayer.h mp3blaster-2-0b16/src/sidplayer.h
--- mp3blaster-2-0b16.orig/src/sidplayer.h	Tue Dec 14 16:37:28 1999
+++ mp3blaster-2-0b16/src/sidplayer.h	Mon Mar 13 17:22:20 2000
@@ -21,7 +21,7 @@
 	void closefile(void) { return SIDfileplayer::closefile(); }
 	void setdownfrequency(int value) {
 		SIDfileplayer::setdownfrequency(value); }
-	void set8bitemode() { SIDfileplayer::set8bitmode(); }
+	void set8bitmode() { SIDfileplayer::set8bitmode(); }
 
 private:
 	int nthreads;