Re: pilot-manager: routine "prettyTime" in PilotMgr.pm is not y2k compliant

[Brian Servis <servis@purdue.edu>]

Yep.

use Time::Local;
[snip]
sub msg
[snip]
        $time = &prettyTime(time);
[snip]
sub prettyTime
{
    my ($time) = @_;
[snip]
    my($sec, $min, $hour, $mday, $mon, $year, $wday, $yday, $isdst);
[snip]
($sec, $min, $hour, $mday, $mon, $year, $wday, $yday, $isdst) =
        ($TZ eq 'GMT') ? gmtime($time) : localtime($time);
[snip]
  return sprintf("%02d/%02d/%02d %2d:%02d:%02d",
                   $mon, $mday, $year, $hour, $min, $sec);

Brian

*- On  1 Jan, Terry Katz wrote about "RE: pilot-manager: routine "prettyTime" in PilotMgr.pm is not y2k compliant"
> most likely, the author used the 'localtime' function to retrieve the date
> .. the year returned by that function is the number of years from 1900 (thus
> 2000 is 100 years from then .. ), and the author didn't add 1900 to that
> number.. (I haven't looked at that package, so I'm just assuming here ;-)
> 
> -Terry
> 
> -----Original Message-----
> From: Brian Servis [mailto:servis@purdue.edu]
> Sent: Saturday, January 01, 2000 11:17 AM
> To: submit@bugs.debian.org
> Cc: debian-devel@lists.debian.org
> Subject: pilot-manager: routine "prettyTime" in PilotMgr.pm is not y2k
> compliant
> 
> 
> Package: pilot-manager
> Version: 1.107-1
> Severity: normal
> 
> The pretty printing of time in the pilot-manager log is not y2k
> compliant.
> 
> 01/01/100 10:07:07   Please press the Hotsync button on your Pilot cradle
>      ^^^^^
> The bug(lazy programming) is in the prettyTime routine in PilotMgr.pm.
> (sorry I don't speak perl well enough submit a patch)
> 
> -- System Information
> Debian Release: potato
> Kernel Version: Linux brian 2.2.13 #1 Tue Nov 16 14:54:04 EST 1999 i686
> unknown
> 
> Versions of the packages pilot-manager depends on:
> ii  libdigest-md5-p 2.09-1         MD5 Message Digest for Perl
> ii  perl-tk         800.015-1      Perl module providing the Tk graphics
> librar
> ii  pilot-link-perl 0.9.3-2        Perl tools to communicate with a 3COM
> Pilot
> ii  perl-5.005      5.005.03-4.1   Larry Wall's Practical Extracting and
> Report
>         ^^^ (Provides virtual package perl5)
> 
>