[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Bug#28345: xdm: doesn't check if in X

In article <19981022002812.F539@worldvisions.ca>, Avery Pennarun <apenwarr@worldvisions.ca> writes:
> On Wed, Oct 21, 1998 at 07:53:26PM -0400, Branden Robinson wrote:
>> > I just upgraded to the latest packages (using apt in X). The xdm
>> > install/upgrade didn't check that it was in X, and went ahead,
>> killing my X, > and leaving the packaging system in an inconsistent
>> state (apt refused to > continue).
>> This is because when upgrading, the old prerm is used, which in
>> this case is xbase's prerm.
>> The new xdm prerm is far more intelligent.  If you don't believe
>> me, read it.
>> I'm open to suggestions regarding the upgrade procedure -- that do
>> not include copying substantially all of the new xdm prerm into its
>> preinst.

I haven't looked at it, but can't you apply the same technique?
I.e., have two checks in xdm preinst:

 * if $DISPLAY is set, prompt user whether they really want to
 continue, possibly having their X session killed. If no, fail.

 * if xdm is disabled in the X config, and we are upgrading from a
 pre-re-org X11, ask whether the user really wants to install xdm,
 since it will start kicking up. If no, fail.

I know the devil is in the details and it is much tougher than this,
but that's the best I can come up with.

.....A. P. Harris...apharris@onShore.com...<URL:http://www.onShore.com/>

Reply to: