[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: dpkg-buildpackage and joe



Heiko Schlittermann writes:
> Perhaps someone should release dpkg_1.4.1 ...  If there are no
> voluntaries, I'd do it.

But please name it 1.4.0.1 (as Ian proposed). :-)

Anyway, there's another nasty problem with dpkg-buildpackage, namely that is
doesn't quote the commands executed via $rootcommand. Here's a patch:

--- dpkg-buildpackage.old	Fri Sep 20 11:25:32 1996
+++ dpkg-buildpackage	Fri Sep 20 11:25:08 1996
@@ -98,12 +98,12 @@
 if [ -n "$version"	]; then set -- "$@" "-v$version"	; fi
 if [ -n "$desc"		]; then set -- "$@" "-C$desc"		; fi
 
-withecho $rootcommand debian/rules clean
+withecho $rootcommand "debian/rules clean"
 if [ x$binaryonly = x ]; then
 	cd ..; withecho dpkg-source -b "$dirn"; cd "$dirn"
 fi
 withecho debian/rules build
-withecho $rootcommand debian/rules $binarytarget
+withecho $rootcommand "debian/rules $binarytarget"
 $signsource "$pv.dsc"
 chg=../"$pva.changes"
 withecho dpkg-genchanges $binaryonly $sourcestyle >"$chg"
@@ -129,7 +129,7 @@
 $signchanges "$pva.changes"
 
 if $cleansource; then
-	withecho $rootcommand debian/rules clean
+	withecho $rootcommand "debian/rules clean"
 fi
 
 echo "dpkg-buildpackage: $srcmsg"

Michael

-- 
Michael Meskes                   |    _____ ________ __  ____
meskes@informatik.rwth-aachen.de |   / ___// ____/ // / / __ \___  __________
meskes@sanet.de                  |   \__ \/ /_  / // /_/ /_/ / _ \/ ___/ ___/
meskes@debian.org                |  ___/ / __/ /__  __/\__, /  __/ /  (__  )
Use Debian GNU/Linux!            | /____/_/      /_/  /____/\___/_/  /____/



Reply to: