[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#4506: bad value assigned to XVDestDir in XView.cf (xview-dev package)



Package: xview-dev
Version: 3.2p1.2-1
Maintainer: Sven Rudolph <sr1@inf.tu-dresden.de>

XVDestDir in /usr/X11R6/lib/X11/config/XView.cf set bad location of xview tree.
At least it should reference /usr/X11R6 instead of
/home/sr1/src/xview/xview-3.2p1.2/debian-tmp/usr/openwin to locate shared
libraries at compile time.

Furthermore, XVDestDir doesn't need to be set if xview applications/libs are
installed in standard X-Window tree (see comments at head of XVDestDir settings
in XView.cf).
I tried that by commenting out these settings but falled in trouble when
I tried to install an application under a temporary directory (say /tmp/top).
Entering:
	make install DESTDIR=/tmp/top
doesn't install every files under /tmp/top, just binaries
(in /tmp/top/usr/X11R6/bin exactly).
Other files, like support and help files, are put under / (/usr/X11R6/lib/help
exactly) :-(.

In fact, rules to install help/support files (InstallNonExecList and
InstallSupportList) don't prepend $(DESTDIR) before destination directories,
like any X-Window rule does.
Maybe rules be changed like that:
--------------------------------------------------------------------------------
/*
 * InstallNonExecList - rule to install a list of help files
 */
#ifndef InstallNonExecList
#define InstallNonExecList(srcs,dest)                                   @@\
install::                                                               @@\
        @case '${MFLAGS}' in *[i]*) set +e;; esac;                      @@\
        for i in srcs ;\                                                @@\
        do \                                                            @@\
                echo "installing $$i"; \                                @@\
-               $(RM) dest/$$i ; \                                      @@\
-               $(INSTALL) -c $(INSTDATFLAGS) $$i dest ; \              @@\
+               $(RM) $(DESTDIR)dest/$$i ; \                            @@\
+               $(INSTALL) -c $(INSTDATFLAGS) $$i $(DESTDIR)dest ; \    @@\
        done
#endif /* InstallNonExecList */
--------------------------------------------------------------------------------

Best regards.

-- 
 Eric Delaunay                 | "La guerre justifie l'existence des militaires.
 delaunay@lix.polytechnique.fr | En les supprimant." Henri Jeanson (1900-1970)



Reply to: