[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1931: less" doesn'

Thanks for sending the info on the two fixes you made in less-290.

I don't quite understand the purpose of the first one.  You said:
>In screen.c, it's presumed that dumb terminals have termcap
>capabilities.  This isn't necessarily true.  I added the
>#ifdef DEBIAN block below to stop a segfault.

Your change causes less to exit immediately when it finds an unknown
type of terminal, rather than trying to run using minimal ("dumb")
capabilities.  I'm not sure what you mean by "it's presumed that dumb
terminals have termcap capabilities."  The ability to handle the termcap
functions (tgetflag, etc.) is a feature of the system, not of the terminal.
It may be that your system's implementation of termcap is failing because
I'm simulating a tgetent() call by simply strcpy'ing a string into termbuf.
This would be unfortunate.  I guess a better solution, if this is the case, is
to not call any termcap functions if tgetent fails, and simply hardcode
some default capabilities.  I will look into this.

I understand your other fix, to workaround the kernel bug having to do
with /proc files (actually, both fixes, yours and the one from Raul Miller).
I will try to incorporate these into my next release (although it bothers
me to have to put cruft in my code to workaround kernel bugs).

Thanks again, and let me know if you find any other problems.

Reply to: