[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

[longo] wmaker -- alertas do compilador



 Olá

 Retirei alguns alertas do compilador reconstruíndo
o pacote wmaker(stable). Gostaria de ouvir opiniões.

 -- 'unused variable' (apaguei)
-wmaker-0.91.0/WINGs/configuration.c:56: warning: unused variable `str'
-wmaker-0.91.0/src/window.c:3307: warning: unused variable `staterec'
-wmaker-0.91.0/util/fontconv.c:133: warning: unused variable `slt'

 -- 'defined but not used' (comentei)
-wmaker-0.91.0/WPrefs.app/Themes.c:151: warning: `updateThemeList' defined but not used

 -- 'braces'
-wmaker-0.91.0/src/framewin.c:156: warning: suggest explicit braces to avoid ambiguous `else'

 -- 'implicit declaration'
-coloquei um '#include <X11/XKBlib.h>' para 
wmaker-0.91.0/src/startup.c:799: warning: implicit declaration of function `XkbQueryExtension'

-coloquei o protótipo, acrescentando 'static void' para
wmaker-0.91.0/src/event.c:496: warning: implicit declaration of function `handleXkbIndicatorStateNotify'
/tmp/buildd/wmaker-0.91.0/src/event.c:1204: warning: return type defaults to `int'
/tmp/buildd/wmaker-0.91.0/src/event.c:1226: warning: control reaches end of non-void function

 a função:
#ifdef KEEP_XKB_LOCK_STATUS
/* please help ]d if you know what to do */
handleXkbIndicatorStateNotify(XEvent *event)
{
    WWindow *wwin;
    WScreen *scr;
    XkbStateRec staterec;
    int i;

    for (i=0; i<wScreenCount; i++) {
        scr = wScreenWithNumber(i);
        wwin = scr->focused_window;
        if (wwin && wwin->flags.focused) {
            XkbGetState(dpy,XkbUseCoreKbd,&staterec);
            if (wwin->frame->languagemode != staterec.group) {
                wwin->frame->last_languagemode = wwin->frame->languagemode;
                wwin->frame->languagemode = staterec.group;
            }
#ifdef XKB_BUTTON_HINT
            if (wwin->frame->titlebar) {
                wFrameWindowPaint(wwin->frame);
            }
#endif
        }
    }
}
#endif /*KEEP_XKB_LOCK_STATUS*/

- coloquei o protótipo em wmaker-0.91.0.hpfn/WINGs/WINGs/WINGsP.h
(parece ser como está na versão do etch -- com nome abreviado) para
wmaker-0.91.0/WINGs/widgets.c:635: warning: implicit declaration of function `W_InitIMStuff'

 Na função eu diria estar faltando um return True, mas não mexi.
A função:
Bool
W_InitIMStuff(WMScreen *scr)
{
    WMIMContext *ctx;

    ctx = scr->imctx = wmalloc(sizeof(WMIMContext));

    ctx->xim = XOpenIM(scr->display, NULL, NULL, NULL);
    if (ctx->xim == NULL) {
        wwarning("could not open IM");
        return False;
    }

}

 Algumas alterações seriam aplicáveis na versão etch. Gostaria de saber 
se concordam com as alterações, se deveria reportar bug(sarge,etch), 
sobre o retorno da função logo acima.


 []
 hpfn

--
Linux user number 416100
Ging
FE1905B2 - ID

Attachment: pgpwEzBnnLsTm.pgp
Description: PGP signature


Reply to: