[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: Updating ogre to 1.12.3 -> 1.12.4



what a wonderful world :D

Just a quick detail question, you changed it from

find_package(SDL2 REQUIRED)

to

find_package(SDL2 REQUIRED CONFIG)

but doesn't it fallback to CONFIG anyway? So simply deleting the
FindSDL2.cmake should be enough?

(CMake 3.15 introduced a flag to prefer CONFIG over MODULE btw)

Am 10.04.20 um 15:06 schrieb Simon McVittie:
> On Fri, 10 Apr 2020 at 14:53:39 +0200, Simon Schmeisser wrote:
>> Yes indeed, I don't know why those headers are in architecture dependent
>> subfolders in Debian
> To make it possible to install libsdl2-dev:amd64 and libsdl2-dev:i386 at
> the same time.
>
> I proposed a libsdl2 change to make this possible in 2018, but it wasn't
> considered acceptable for whatever reason, so I proposed two more possible
> approaches in an attempt to get things moving, and the libsdl2 maintainers
> applied one of the new approaches.
>
> Unfortunately, this caused regressions for lots of packages that use
> FindSDL2.cmake:
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=951087
>
> I consider this to be a RC bug in libsdl2, and I have proposed a solution
> for it (which is essentially the same thing I proposed the first time,
> in 2018), but I haven't had any response other than a non-maintainer
> essentially saying "those packages were wrong anyway" (which might be
> true, but a regression is a regression).
>
> I think the best solution for this would be to fix the dependent packages
> *and* fix libsdl2.
>
>> and why neither the cmake.config nor the pkgconfig
>> gets used by ogre but I'll add this patch and discuss it with ogre upstream
> FindSDL2.cmake is fragile and easily broken by distro changes like this
> one, so it would be better to see whether they would accept a patch to
> drop FindSDL2.cmake and rely on SDL >= 2.0.4's sdl2-config.cmake instead,
> similar to this one: https://github.com/JACoders/OpenJK/pull/1033
>
>     smcv
>


Reply to: