Hi Miry, Hi Olek,
I tried enabling python3 bindings like Miry did but the official tar.gz are missing imgui. Apparently it should be fetched as a git submodule but that does not work in githubs release process: https://github.com/OGRECave/ogre/issues/1332
If disabling the imgui overlay the python bindings won't build: https://github.com/OGRECave/ogre/issues/1392
I could add a patch to fix #1392 but as the ogre lead dev suggested it would make more sense to include imgui and use the git tag with submodule instead of the github tar.gz. I'm not sure how to document that in version numbers (1.12.4+git20191223+dfsg1 ?) and how to tell gbp to do this. Any ideas?
Thanks a lot
Simon
Wait a second, upstream OGRE doesn't have Python 3 binding yet?? That's strange, I'll take another look at the code. Miry brings up a good point, with Python 2 removal in full swing we should ensure a new package supports 3.
-Olek
On Mon, Dec 23, 2019, 10:49 Miriam Ruiz <miriam@debian.org> wrote:
I will try to have a look at it. But, as I need the Python bindings for myself, I guess I'll have to, at least, add them to whatever packages I might be using.
Thanks,Miry
El lun., 23 dic. 2019 14:37, Simon Schmeisser <s.schmeisser@gmx.net> escribió:
Hi Miry,
sorry for not getting back to you earlier. I worked together with Olek
to get ogre packaging into shape. You can find the current status here
https://salsa.debian.org/games-team/attic/ogre/tree/master-1.12-updates
Please have a look if you still have issues with the CMake files and
maybe provide an example CMakeLists.txt?
I would suggest to first try to get this released into Debian as is and
then try to incorporate the language bindings you enabled in a second
upload?
Greetings
Simon
On 22.11.19 13:13, Miriam Ruiz wrote:
> Oh, btw, among the scripts that don't seem to be working yet are the
> cmake related files in the binary packages. At least for me.
>
> Greetings,
> Miry
>
> El vie., 22 nov. 2019 a las 12:17, Miriam Ruiz (<miriam@debian.org>) escribió:
>> Hi,
>>
>> I made some improvements on your packages for my personal use (
>> http://miriamruiz.es/debian/ogre/ ), as I've started to play around
>> with ogre a bit myself. I included the bindings for Python3, Java and
>> CLI, even though I have only actually tested the Python 3 ones (which
>> I am using for some tests and experiments myself). My current packages
>> are still very far away from any reasonable QA level so as to be
>> uploadable to Debian, but for the moment they might be OK for me. Feel
>> free to take a look at them if you might think that the bindings might
>> be an interesting thing to add to your package.
>>
>> Greetings,
>> Miry
>>
>> El sáb., 9 nov. 2019 a las 22:57, Markus Koschany (<apo@debian.org>) escribió:
>>> Hi Simon,
>>>
>>> Am 09.11.19 um 21:02 schrieb Simon Schmeisser:
>>>> Hi All,
>>>>
>>>> I'm new to Debian development so please excuse me if this is the wrong
>>>> place to ask. We use rviz at work which uses ogre as its rendering
>>>> engine. I would like to update the Debian (and Ubuntu) package to the
>>>> current upstream release (from 1.9.0 to 1.12.3).
>>> You are at the right place. Thank you for updating Ogre.
>>>
>>>
>>>> I uploaded a modified
>>>> package to mentors.debian.org but did not get any feedback. The current
>>>> maintainer responded to direct mail that he is too busy to continue
>>>> working on this package.
>>>>
>>>> Could anybody guide me as to what the next steps would be?
>>> I just had a look at your package. The first impression was positive and
>>> I think you only need some small changes for ogre-1.12 before we can
>>> upload it.
>>>
>>> 1. Please merge the changelog entries since the last official upload to
>>> Debian.
>>>
>>> 2. debian/control: Remove libogre-1.12.1v1-dbg because this one is
>>> obsolete and probably a search and replace error.
>>>
>>> 3. debian/control: You can replace debhelper (>= 12~) with
>>> debhelper-compat (= 12) and remove debian/compat.
>>>
>>> 4. debian/control: The build-dependency on dpkg-dev (>= 1.16.1~)
>>> shouldn't be necessary anymore.
>>>
>>> 5. debian/rules: You can remove --dbgsym-migration='libogre-1.12-dbg (<<
>>> 1.12.2+dfsg0-1~)' because the migration to dbgsym packages has been
>>> successful. Ogre-1.9 doesn't provide -dbg packages anymore.
>>>
>>> There are a lot of libogre-1.12.2v1* files. I don't think they are
>>> really needed because you also use libogre-1.12* files. The v1 version
>>> or v5 suffix in ogre-1.9 was only necessary to rebuild ogre against a
>>> newer gcc version back then.
>>>
>>> Please add yourself to Uploaders in debian/control. You can find more
>>> suggestions for improvements at
>>>
>>> https://mentors.debian.net/package/ogre-1.12
>>>
>>> Most of them are minor but also easy to fix. The only think you don't
>>> need to fix is testsuite-autopkgtest-missing because we don't have a
>>> general solution for games packages yet.
>>>
>>> I still need to check the copyright file but there is already a warning
>>> about missing-license-text-in-dep5-copyright. This is probably just a
>>> syntax error in debian/copyright because there is a Comment section
>>> before the actual license text, so just move the license text before the
>>> Comment, then it should be ok.
>>>
>>> Please request Debian Games membership at
>>> https://salsa.debian.org/games-team, then I can grant you access to our
>>> Git repository and you can just upload your work to Git.
>>>
>>> So far
>>>
>>> Cheers,
>>>
>>> Markus
>>>
>>>