[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: New libode version



well, review starting:

1) ode (2:0.13.1~git20150309-1) UNRELEASED; urgency=low



please set to unstable.

0.13.1~git is < 0.13.1 but you said

* New upstream release: 0.13.1 with a patch (Closes: #670746)


so either use a > version or start from 0.13.1 and add your patch.

I would consider good a versioning like
2:0.13.1+git20150309-1

(there is a way to compare two versions with dpkg)
dpkg --compare-versions 1 gt 0

- Bump standards-version to 3.9.4

* Bump standards to 3.9.6. No changes


well, I would avoid such duplication


- Build-depend on dh-autoreconf

* Rename packages to a new version of Sonames Changed dh-autoreconf
to autotools-dev, automake and libtool



(please use autoreconf instead of autotools if possible, and remove automake, autotools-dev
libtool from build-dependencies)


rules:
--libdir='$${prefix}/lib/$(DEB_HOST_MULTIARCH)/'

this should be automagically injected by dh_auto_configure, isn't it?


cat debian/libode4.install

#! /usr/bin/dh-exec
usr/lib/${DEB_HOST_MULTIARCH}/lib*.so.*




well,
doesn't something like
usr/lib/*/lib*.so.* work?

same for the -dev

question: do you really need to ship a static library?

I personally don't like them for security reasons, but I can't object if you need it :)



BTW you are providing a shared library with a git snapshot, are you sure about this?

this is what I did so far, feel free to finish the work if you agree

it doesn't work the install target
/build/ode-0.13.1~git20150309/debian/libode4.install: 1: /build/ode-0.13.1~git20150309/debian/libode4.install: usr/lib/*/lib*.so.*: not found
dh_install: problem reading debian/libode4.install: 


strange, files are on debina/tmp/ correctly.

cheers,
G.

Attachment: patch
Description: Binary data


Reply to: