[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: endless-sky/0.7.9-1 [ITP]

Thanks for the quick feedback!

If SSE 4.1 is not acceptable, is it possible to at least depend on SSE 3? I use some SSE intrinsics to optimize geometric calculations. Should I modify the code so those instructions are used only if a special command line option is given? That would mean all the official packages would be un-optimized, even though all i386 and amd64 processors from the last decade support SSE 3.

For libjpeg, right now I use the JCS_EXT_BGRA option (converting to 32-bit BGRA color when decoding JPEGs). The reason I specified libpeg-turbo is because other libjpeg implementations may not include that extension. (But, I see that libjpeg-turbo is the default implementation of libjpeg on Debian, anyway.) Is it safe to just specify plain libjpeg as the dependency?


On 04/18/2015 04:33 PM, James Cowgill wrote:
On Sat, 2015-04-18 at 14:31 -0400, Michael Zahniser wrote:
    Dear mentors,

    I am looking for a sponsor for my package "endless-sky".

Here are some comments:

The build passes -msse4.1 to g++. This will fail on non-x86 arches and
produce binaries which don't work without sse 4.1 processors on x86

libjpeg-turbo8-dev does not exist in debian, try libjpeg-dev
Latest standards version is 3.9.6

You need copies of CC-BY-SA-3.0 and CC-BY-3.0

You should not hardcode -j4 in the rules file. Use the value given in
DEB_BUILD_OPTIONS 'parallel' instead (see policy 4.9.1).

Lintian output:
W: endless-sky: hardening-no-relro usr/games/endless-sky
I: endless-sky: hardening-no-fortify-functions usr/games/endless-sky
I: endless-sky: description-synopsis-might-not-be-phrased-properly
I: endless-sky: hyphen-used-as-minus-sign usr/share/man/man6/endless-sky.6.gz:7
I: endless-sky: desktop-entry-lacks-keywords-entry usr/share/applications/endless-sky.desktop
I: endless-sky-data: description-synopsis-might-not-be-phrased-properly
P: endless-sky: no-upstream-changelog
P: endless-sky-data: no-upstream-changelog

The warning should be fixed. That one is usually caused by the build
system ignoring custom CFLAGS/CXXFLAGS/etc. The others would be nice to
fix as well but are not essential.

Otherwise, the package looks good - I'm not a DD though so I can't
upload the package for you when it's done.


Reply to: